Skip to content

fix: expose retry-after header#7832

Merged
Zaimwa9 merged 1 commit into
mainfrom
fix/cors-expose-retry-after
Jun 19, 2026
Merged

fix: expose retry-after header#7832
Zaimwa9 merged 1 commit into
mainfrom
fix/cors-expose-retry-after

Conversation

@Zaimwa9

@Zaimwa9 Zaimwa9 commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

  • The header retry-after providing the remaining time before another experiment refresh is computable can not be read by the frontend without exposing it through cors

How did you test this code?

  • Implementing the frontend consuming the header

@Zaimwa9 Zaimwa9 requested a review from a team as a code owner June 19, 2026 09:26
@Zaimwa9 Zaimwa9 requested review from emyller and removed request for a team June 19, 2026 09:26
@vercel

vercel Bot commented Jun 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Building Building Preview, Comment Jun 19, 2026 9:26am
flagsmith-frontend-preview Building Building Preview, Comment Jun 19, 2026 9:26am
flagsmith-frontend-staging Building Building Preview, Comment Jun 19, 2026 9:26am

Request Review

@Zaimwa9 Zaimwa9 changed the title fix: expose Retry-After header via CORS fix: expose retry-after header via CORS Jun 19, 2026
@Zaimwa9 Zaimwa9 changed the title fix: expose retry-after header via CORS fix: expose retry-after header Jun 19, 2026
@github-actions github-actions Bot added api Issue related to the REST API fix labels Jun 19, 2026
@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-7832 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-7832 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-7832 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-7832 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-7832 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7832 Finished ✅ Results

@Zaimwa9 Zaimwa9 requested review from gagantrivedi and removed request for emyller June 19, 2026 09:27
@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.58%. Comparing base (1bdb7ca) to head (4e14ef9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7832   +/-   ##
=======================================
  Coverage   98.58%   98.58%           
=======================================
  Files        1466     1466           
  Lines       57010    57010           
=======================================
  Hits        56203    56203           
  Misses        807      807           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  42 seconds
commit  4e14ef9
info  🔄 Run: #17667 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  45.3 seconds
commit  4e14ef9
info  🔄 Run: #17667 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  32.7 seconds
commit  4e14ef9
info  🔄 Run: #17667 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  18.4 seconds
commit  4e14ef9
info  🔄 Run: #17667 (attempt 1)

@github-actions

Copy link
Copy Markdown
Contributor

Visual Regression

19 screenshots compared. See report for details.
View full report

@Zaimwa9 Zaimwa9 merged commit 5266950 into main Jun 19, 2026
33 checks passed
@Zaimwa9 Zaimwa9 deleted the fix/cors-expose-retry-after branch June 19, 2026 11:13
Zaimwa9 added a commit that referenced this pull request Jun 19, 2026
Use queryFn to access response headers from fetchBaseQuery, extract
the Retry-After value on 429 responses, and pass it through the
error object so the exposures panel shows an accurate countdown.
Requires CORS_EXPOSE_HEADERS on the backend (PR #7832).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants