Fix audit task DB connection leaks in E2E runs#7827
Closed
Copilot wants to merge 2 commits into
Closed
Conversation
for more information, see https://pre-commit.ci
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Member
|
I'm fascinated by how copilot sees red CI and just... stops. Like, Github, it's your own freaking product goddammit. Other harnesses suffer from lack of feedback, but you provide tons of your own via CI... |
Copilot stopped work on behalf of
khvn26 due to an error
June 18, 2026 17:00
Copilot created this pull request from a session on behalf of
khvn26
June 18, 2026 17:00
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Contributes to https://github.com/Flagsmith/flagsmith/actions/runs/27771948370/job/82174969654
Investigated the failing private-cloud E2E run and traced it to
create_audit_log_from_historical_recordtasks opening database connections in separate threads without releasing them. During the project permissions test this exhausted Postgres connections and caused the UI assertions to fail.This PR closes Django database connections in that audit task when it runs via
SEPARATE_THREAD, and adds unit coverage for both the success path and exception path.How did you test this code?
cd /home/runner/work/flagsmith/flagsmith/api && make test opts='tests/unit/audit/test_unit_audit_tasks.py -n0'cd /home/runner/work/flagsmith/flagsmith/api && uv run pre-commit run --files audit/tasks.py tests/unit/audit/test_unit_audit_tasks.pycodeql_checker(0 alerts)cgr.devwhile building the API image forfrontend/docker-compose-e2e-tests.yml.