Skip to content

fix(Local): Fix make install#7808

Merged
emyller merged 5 commits into
mainfrom
fix/api-makefile
Jun 18, 2026
Merged

fix(Local): Fix make install#7808
emyller merged 5 commits into
mainfrom
fix/api-makefile

Conversation

@emyller

@emyller emyller commented Jun 18, 2026

Copy link
Copy Markdown
Contributor
  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Require uv, and fix make install in the api directory:

  • python unavailable in CLI: on MacOS, only python3 is linked by default.
  • python -m pip is broken os OS-level Python installation. See why.

How did you test this code?

$ git clone git@github.com:Flagsmith/flagsmith.git
$ cd flagsmith/api
$ make install  # works

On MacOS, and in Linux too.

@emyller emyller self-assigned this Jun 18, 2026
@vercel

vercel Bot commented Jun 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview Jun 18, 2026 3:52pm
flagsmith-frontend-preview Ignored Ignored Preview Jun 18, 2026 3:52pm
flagsmith-frontend-staging Ignored Ignored Preview Jun 18, 2026 3:52pm

Request Review

@github-actions github-actions Bot added api Issue related to the REST API fix labels Jun 18, 2026
@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.58%. Comparing base (40323e3) to head (13eeb46).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7808   +/-   ##
=======================================
  Coverage   98.58%   98.58%           
=======================================
  Files        1465     1465           
  Lines       56889    56889           
=======================================
  Hits        56082    56082           
  Misses        807      807           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added fix and removed fix labels Jun 18, 2026
@emyller emyller marked this pull request as ready for review June 18, 2026 11:36
@emyller emyller requested a review from a team as a code owner June 18, 2026 11:36
@emyller emyller requested review from khvn26 and removed request for a team June 18, 2026 11:36
@github-actions github-actions Bot added fix and removed fix labels Jun 18, 2026
@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-7808 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-7808 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-7808 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-7808 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7808 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-7808 Finished ✅ Results

khvn26
khvn26 previously approved these changes Jun 18, 2026
@emyller emyller force-pushed the fix/api-makefile branch from 9ae5883 to 609d6d4 Compare June 18, 2026 15:39
@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  41.3 seconds
commit  609d6d4
info  🔄 Run: #17643 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  45.2 seconds
commit  609d6d4
info  🔄 Run: #17643 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

failed  1 failed

Details

stats  1 test across 1 suite
duration  48.7 seconds
commit  609d6d4
info  📦 Artifacts: View test results and HTML report
🔄 Run: #17643 (attempt 1)

Failed tests

firefox › tests/project-permission-test.pw.ts › Project Permission Tests › Project-level permissions control access to features, environments, audit logs, and segments @enterprise

### Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  4.4 seconds
commit  13eeb46
info  🔄 Run: #17644 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  35.2 seconds
commit  13eeb46
info  🔄 Run: #17644 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

failed  1 failed

Details

stats  1 test across 1 suite
duration  49.7 seconds
commit  13eeb46
info  📦 Artifacts: View test results and HTML report
🔄 Run: #17644 (attempt 1)

Failed tests

firefox › tests/project-permission-test.pw.ts › Project Permission Tests › Project-level permissions control access to features, environments, audit logs, and segments @enterprise

### Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  37.3 seconds
commit  609d6d4
info  🔄 Run: #17643 (attempt 2)

@github-actions

Copy link
Copy Markdown
Contributor

Visual Regression

19 screenshots compared. See report for details.
View full report

@github-actions github-actions Bot added fix and removed fix labels Jun 18, 2026

@khvn26 khvn26 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions.

Comment thread .github/actions/install-uv/action.yml
Comment thread mcp/pyproject.toml
Comment thread Dockerfile
Comment thread api/README.md

@khvn26 khvn26 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emyller emyller merged commit 294e591 into main Jun 18, 2026
39 of 41 checks passed
@emyller emyller deleted the fix/api-makefile branch June 18, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants