test(e2e): drop waitForLoadState('networkidle') from helpers#7784
Closed
talissoncosta wants to merge 1 commit into
Closed
test(e2e): drop waitForLoadState('networkidle') from helpers#7784talissoncosta wants to merge 1 commit into
talissoncosta wants to merge 1 commit into
Conversation
The dashboard loads HubSpot, LinkedIn, Google Ads and Chargebee trackers that fire pixels/polling indefinitely, so 'networkidle' never settles and times out after 20s even though the page is ready (observed in gotoTraits and createTag). Playwright discourages networkidle for this reason. Each call was immediately followed by a concrete element wait, which is the real readiness signal, so the networkidle calls are redundant as well as flaky. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
the
front-end
Contributor
Docker builds report
|
Contributor
Author
|
Superseded by #7785, which consolidates the E2E flakiness fixes into one branch. |
Contributor
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
|
Contributor
Visual Regression19 screenshots compared. See report for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Another intermittent E2E failure on the production deploy gate, distinct from the boot deadlock (#7776) and the permission write-race (#7782). Here the app is fully booted and on the right page, but
page.waitForLoadState('networkidle')times out after 20s.The dashboard loads HubSpot, LinkedIn, Google Ads and Chargebee scripts that fire tracking pixels and polling indefinitely, so the network never goes idle for 500ms and
networkidlecan't resolve regardless of whether the page is ready. Playwright explicitly discouragesnetworkidlefor this reason.All four uses in the helpers (
gotoTraits, the role-assignment helper,createEnvironment,createTag) were immediately followed by a concrete element wait — the real readiness signal — so thenetworkidlecalls are redundant as well as flaky. Removed all four.How did you test this code?
Observed the timeout in two captured failures (
gotoTraitsline 231 in environment-permission-test, andcreateTagline 915 in flag-tests), both with a fully-rendered page in the snapshot. Confirmed each removed call is followed by a deterministicwaitForElementVisible/waitForthat already gates readiness.