Skip to content

fix: Normalise heap base url and add request coverage#7747

Merged
matthewelwell merged 1 commit into
mainfrom
test/heap-base-url-coverage
Jun 11, 2026
Merged

fix: Normalise heap base url and add request coverage#7747
matthewelwell merged 1 commit into
mainfrom
test/heap-base-url-coverage

Conversation

@Zaimwa9

@Zaimwa9 Zaimwa9 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

  • New tests asserting identify_integrations posts to the correct Heap URL for default, empty, and EU base_url values
  • Small fix surfaced by the test: normalising trailing slash to avoid //api/track

How did you test this code?

  • tests

@Zaimwa9 Zaimwa9 requested a review from matthewelwell June 10, 2026 16:12
@Zaimwa9 Zaimwa9 requested a review from a team as a code owner June 10, 2026 16:12
@vercel

vercel Bot commented Jun 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Jun 10, 2026 4:12pm
flagsmith-frontend-preview Ignored Ignored Jun 10, 2026 4:12pm
flagsmith-frontend-staging Ignored Ignored Jun 10, 2026 4:12pm

Request Review

@github-actions github-actions Bot added the api Issue related to the REST API label Jun 10, 2026
@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.55%. Comparing base (5ef4042) to head (5313961).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7747      +/-   ##
==========================================
+ Coverage   98.48%   98.55%   +0.06%     
==========================================
  Files        1453     1453              
  Lines       55809    55847      +38     
==========================================
+ Hits        54964    55040      +76     
+ Misses        845      807      -38     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  46.3 seconds
commit  5313961
info  🔄 Run: #17401 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  34.3 seconds
commit  5313961
info  🔄 Run: #17401 (attempt 2)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  44 seconds
commit  5313961
info  🔄 Run: #17401 (attempt 2)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  33.9 seconds
commit  5313961
info  🔄 Run: #17401 (attempt 2)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  1 minute, 1 second
commit  5313961
info  🔄 Run: #17401 (attempt 2)

@github-actions github-actions Bot added the fix label Jun 11, 2026
@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-7747 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-7747 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-7747 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-7747 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-7747 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7747 Finished ✅ Results

@github-actions

Copy link
Copy Markdown
Contributor

Visual Regression

19 screenshots compared. See report for details.
View full report

@matthewelwell matthewelwell changed the title fix: normalise-heap-base-url-and-add-request-coverage fix: Normalise heap base url and add request coverage Jun 11, 2026
@matthewelwell matthewelwell merged commit 79a1673 into main Jun 11, 2026
41 of 50 checks passed
@matthewelwell matthewelwell deleted the test/heap-base-url-coverage branch June 11, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants