feat: added tests for n plus 1 queries in metrics view#7728
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Docker builds report
|
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7728 +/- ##
=======================================
Coverage 98.54% 98.54%
=======================================
Files 1452 1452
Lines 55793 55808 +15
=======================================
+ Hits 54983 54998 +15
Misses 810 810 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Visual Regression19 screenshots compared. See report for details. |
|
@gemini-code-assist review |
There was a problem hiding this comment.
Code Review
This pull request adds a new unit test, test_list_metrics__multiple_attachments__no_n_plus_one, to api/tests/unit/experimentation/test_metric_views.py to verify that listing metrics with multiple attachments does not trigger N+1 database queries. There are no review comments, so I have no feedback to provide.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
How did you test this code?