Permit Management by alexshchur · Pull Request #57 · FhenixProtocol/cofhesdk

alexshchur · 2025-12-02T11:51:52Z

This pull request introduces a new "Permits" feature to the floating button UI in the React package, adds supporting components, and improves code modularity and maintainability. The main changes include new pages for viewing, generating, and receiving permits, integration of these pages into the floating button navigation, and the addition of reusable UI components for permit creation. It also refactors imports for consistency and adds dependencies for SVG handling.

New Permits Feature Integration:

Added new pages for permits: PermitsListPage, GeneratePermitPage, and ReceivePermitPage, and integrated them into the floating button navigation and context (FnxFloatingButtonContext.tsx, ContentSection.tsx, MainPage.tsx, pages/index.ts). [1] [2] [3] [4] [5]

Reusable UI Components for Permit Creation:

Introduced modular components for the permit generation form: ExpirySection, NameSection, ReceiverSection, and SelfToggle to improve code reusability and clarity. [1] [2] [3] [4]

Floating Button UI Improvements:

Enhanced the floating button content section to support dynamic page content, including new permits pages and automatic height adjustment using ResizeObserver.

Codebase Maintenance and Refactoring:

Refactored import paths to use the @/ alias for hooks and utilities, improving consistency and maintainability across multiple files. [1] [2] [3]

Development Dependency Updates:

Added @svgr/core and @svgr/plugin-jsx to devDependencies in package.json to enable SVG component handling.

… page

…ed/received)

… to revisit

alexshchur · 2025-12-03T08:40:25Z

+    setDurationSeconds,
+    handleSubmit,
+  } = usePermitForm({
+    onSuccess: navigateToPermits, // TODO: also add toast here?


wdyt guys, should there be some toast or other kind of feedback upon creating a permit?

Yes I agree, toast system would be very useful

alexshchur · 2025-12-03T08:41:44Z

+            .filter((hash) => {
+              const serializedPermit = allPermits[hash];
+              if (!serializedPermit) {
+                // TODO: revisit: right now, the way removal works, is that a key remains, but the value becomes undefined. https://github.com/FhenixProtocol/cofhesdk/blob/master/packages/sdk/permits/store.ts#L113


i wonder if we should actually delete instead?

The reason I didn't delete was because I thought that it doesn't play nicely in reactive environments, but that was a feeling and not something I checked. If delete doesn't break anything I'm happy to add it

Either way if we are keeping it it should be return serializedPermit != null

alexshchur · 2025-12-03T08:43:24Z

          state.activePermitHash[chainId][account] = otherPermitHash;
        } else {
          if (!force) {
+            // TODO: is swallowed. Fix it


I'll see if I can deliver a fix in a separate PR

Any idea why this is being swallowed, I cant track where this is happening

apparently because permit removal is wrapped with result wrapper and catchFn is not provided, it wouldn't throw any error, and if you need to handle an error you need to look into the result

here's the fix

A bit counterintuitive. I wonder if there's a way to make it more intuitive

Hmm, seems that the result wrappers aren't as useful as I hoped they would be. Maybe its worth considering removing them.

architect-dev

Generally not a fan of having multiple hooks.ts files sprinkled throughout the codebase. I'd prefer to have a single hooks folder with everything contained. I'm seeing a lot of '../../../../../../hooks/useCopyFeedback' stuff which I don't like. Can be refactored later though before it goes into master.

architect-dev · 2025-12-03T11:28:26Z

+    setDurationSeconds,
+    handleSubmit,
+  } = usePermitForm({
+    onSuccess: navigateToPermits, // TODO: also add toast here?


Yes I agree, toast system would be very useful

architect-dev · 2025-12-03T11:41:21Z


+  // React to dynamic size changes inside the active page (e.g., toggling fields)
+  useEffect(() => {
+    if (!showPopupPanel) return;


Is it necessary? The content panel isn't able to dynamically resize based on the child content?

architect-dev · 2025-12-03T11:42:56Z

+            .filter((hash) => {
+              const serializedPermit = allPermits[hash];
+              if (!serializedPermit) {
+                // TODO: revisit: right now, the way removal works, is that a key remains, but the value becomes undefined. https://github.com/FhenixProtocol/cofhesdk/blob/master/packages/sdk/permits/store.ts#L113


The reason I didn't delete was because I thought that it doesn't play nicely in reactive environments, but that was a feeling and not something I checked. If delete doesn't break anything I'm happy to add it

architect-dev · 2025-12-03T11:43:49Z

+            .filter((hash) => {
+              const serializedPermit = allPermits[hash];
+              if (!serializedPermit) {
+                // TODO: revisit: right now, the way removal works, is that a key remains, but the value becomes undefined. https://github.com/FhenixProtocol/cofhesdk/blob/master/packages/sdk/permits/store.ts#L113


Either way if we are keeping it it should be return serializedPermit != null

architect-dev · 2025-12-03T11:47:23Z

+ * - Copies provided text to clipboard and exposes transient "copied" state per key.
+ * - Useful for lists where each row has a copy action and needs quick feedback.
+ */
+export function useCopyFeedback(defaultDurationMs: number = 2000) {


cool system, haven't ever done it this way myself but it makes sense 👍

did you hear, @copilot ? Good job

architect-dev · 2025-12-03T11:48:47Z

          state.activePermitHash[chainId][account] = otherPermitHash;
        } else {
          if (!force) {
+            // TODO: is swallowed. Fix it


Any idea why this is being swallowed, I cant track where this is happening

Copilot · 2025-12-03T15:01:58Z

@alexshchur I've opened a new pull request, #58, to work on those changes. Once the pull request is ready, I'll request review from you.

…into feat/APPS-109-permit-management

alexshchur · 2025-12-04T08:46:20Z

@architect-dev , seem to be 2 distinct issues here:

Generally not a fan of having multiple hooks.ts files sprinkled throughout the codebase. I'd prefer to have a single hooks folder with everything contained.

is it better for you like this?

I'm seeing a lot of '../../../../../../hooks/useCopyFeedback' stuff which I don't like. Can be refactored later though before it goes into master.

I came up with an alias here. Wdyt?

…into feat/APPS-109-permit-management

alexshchur added 30 commits November 27, 2025 13:40

connect empty permits page to the existing setup

8f96b25

draft visual permits management page

6bbbd65

tmp: allow for permit page to have an isolated look & feel

51af977

feat: permit page: dark/light theme

af72104

feat: draft / visual-only 'generate permit page'

227c617

fix: generate permit page: icon

0d3b304

allow direct import of svg and import proper icon for generate permit…

ef57e9d

… page

feat: receive permit visual draft

393cc66

fix svg icon

15194ed

eslint fix

b86a854

link 'permits page' to the menu

a1fef57

react floating button: permits list: un-hardcode the list

326edae

better organize folders

dc3391c

turn permits list sections into mutually exclusive accordion (generat…

7bfacf4

…ed/received)

abstract out accordion into a reusable component

fb303bf

resort to static accordion for now

1cb4421

feat: permit list: employ deletion

b91acfa

add an annotation about a swallowed error

6914413

feat: add and export useCofheClient for usability

a412b72

unhardcode permits creation (ignores form's params for now)

cdf21d6

add annotation for later

00901f0

fix: avoid overlap so actions are visible in permits list

b325af1

fix: skip removed permits to avoid it throwing error + add annotation…

9a74f45

… to revisit

add permit name input

04ad97d

extract permit form logic into usePermitForm

6824807

refine navigation upon form submitting

a62bb22

add 'shared' permit support

af03971

unhardcode expiration params when creating a permit

66cfb10

create permit form: allow custom duration

f452196

abstract out usePermitDuration

3722694

alexshchur added 3 commits December 3, 2025 08:18

better organize permits list page

4eaeda3

polished structure of PermitsListPage

e911a20

polish ReceivePermitPage struct

b735228

alexshchur commented Dec 3, 2025

View reviewed changes

Comment thread packages/sdk/permits/validation.ts Outdated

alexshchur marked this pull request as ready for review December 3, 2025 08:46

alexshchur requested review from architect-dev and tovi-fhe December 3, 2025 08:46

architect-dev requested changes Dec 3, 2025

View reviewed changes

alexshchur added 4 commits December 3, 2025 16:29

fix: error not propagated upon removal

57224ac

chore: cleanup old annotation

f16143c

better default expiration

b7f52c7

improve types and cleanup

c843a6c

Copilot AI mentioned this pull request Dec 3, 2025

No changes required - comment was acknowledgment only #58

Closed

alexshchur added 5 commits December 3, 2025 17:06

cleanup annotations

cc6e053

fix: consistency tests after making default permit date dynamic

2077723

Merge branch 'staging' of https://github.com/FhenixProtocol/cofhesdk …

8ff50ac

…into feat/APPS-109-permit-management

chore: flatten hooks

cd7abf7

chore; react: allow alias for shorter import paths

5e7e1eb

alexshchur requested a review from architect-dev December 4, 2025 08:46

architect-dev approved these changes Dec 9, 2025

View reviewed changes

alexshchur added 3 commits December 9, 2025 17:33

Merge branch 'staging' of https://github.com/FhenixProtocol/cofhesdk …

afebb3e

…into feat/APPS-109-permit-management

fix: typecheck

b471480

fix: typecheck

3496701

alexshchur merged commit aceb97e into staging Dec 9, 2025
2 checks passed

alexshchur deleted the feat/APPS-109-permit-management branch December 9, 2025 15:44

Conversation

alexshchur commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

architect-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI commented Dec 3, 2025

Uh oh!

alexshchur commented Dec 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

alexshchur commented Dec 2, 2025 •

edited

Loading