Repository navigation
docs(foundry): add the remappings the mocks need to compile - #443
Merged
architect-dev merged 1 commit intoOct 19, 2026
Merged
Conversation
|
architect-dev
approved these changes
Oct 19, 2026
architect-dev
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
foundry.tomlon the Foundry docs page doesn't compile a test that inheritsCofheTest. Two remappings are missing:@openzeppelin/contracts-upgradeable/: the 1.0 mocks import it (Permissioned.sol,ACPShareRegistry.sol). feat: share metadata labels and the pointer-based share registry #389 added it to the plugin README but not to the docs page. Without it forge stops withSource "@openzeppelin/contracts-upgradeable/proxy/utils/Initializable.sol" not found.hardhat/:MockCoFHE.solimportshardhat/console.sol, which a Foundry project doesn't have. The plugin's ownfoundry.tomlandcofhe-foundry-startermap it to forge-std'sconsole.sol(hardhat/=node_modules/forge-std/src/). Without it the build fails withSource "hardhat/console.sol" not found. The plugin README is missing this one too.I added both to the docs page and
hardhat/to the README. To check, I set up a project with the packages undernode_modulesand the docs quick-start test (deployMocks(),createCofheClient(),connect()). With the current remappings it fails on each missing source in turn. With these changes it builds and the test passes, using either the docs page's remappings or the README's.