Conversation
|
@burak33bb is attempting to deploy a commit to the Fhenix Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: 323b575 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
burak33bb
force-pushed
the
codex/fix-zk-metadata-large-chainid
branch
from
September 3, 2026 01:56
e3a1b38 to
0e9d17a
Compare
Author
|
Rebased onto the latest master and re-ran the focused SDK test, lint, and build. The change is still focused and ready from my side. @architect-dev — when you get a chance, could you let me know whether this is still something you'd like to merge? Happy to keep it updated, or close it if it's no longer needed. Thanks! |
burak33bb
force-pushed
the
codex/fix-zk-metadata-large-chainid
branch
from
September 13, 2026 11:10
0e9d17a to
323b575
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
constructZkPoKMetadatawriteschainIdas a 32-byte uint, but the previous loop used>>>. JavaScript bitwise operators coerce through uint32, so chain IDs above 32 bits were truncated in the proof metadata whilezkVerifystill sent the fullchain_idin the request payload.Testing
pnpm --filter @cofhe/sdk exec vitest run --project node core/test/zkPackProveVerify.test.tspnpm --filter @cofhe/sdk lint(passes with existing warnings)pnpm --filter @cofhe/sdk buildNot run to completion locally:
pnpm run test:setuprequiresTEST_PRIVATE_KEYfor@cofhe/test-setuppnpm --filter @cofhe/sdk testneeds the Playwright browser binary for the web project and the test setup fixturepnpm --filter @cofhe/sdk check:typescurrently fails because@cofhe/test-setupis not generated without setup