fix: replace raw console.error with logger utility (closes #848)#872
Merged
Ejirowebfi merged 4 commits intoJun 25, 2026
Merged
Conversation
zeekman
force-pushed
the
fix/replace-console-error-with-logger
branch
from
c5a3947 to
285c5ee
Compare
…adataUploadForm Closes Favourorg#848 — adds a thin logger utility (utils/logger.ts) that suppresses errors in production and is ready to forward to Sentry when integrated. Replaces the three ad-hoc console.error calls cited in the issue with logger.error. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
zeekman
force-pushed
the
fix/replace-console-error-with-logger
branch
from
baa19eb to
24805af
Compare
- Add 'standalone' to Network type and NETWORK_CONFIGS (localhost:8000) so the app no longer crashes when VITE_NETWORK=standalone (CI setting) - Update NetworkContext, WalletService.getBalance/signTransaction to accept the new network variant - Add standalone entries to NetworkBadge color/label maps - Fix wallet-mock.ts to intercept @stellar/freighter-api postMessage protocol (REQUEST_PUBLIC_KEY, REQUEST_CONNECTION_STATUS, etc.) so connect() succeeds in E2E tests; also pre-accept ToS to prevent modal blocking the flow - Fix e2e-setup.ts to use local Friendbot (localhost:8000) instead of the public testnet Friendbot, matching the CI docker-compose setup Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ETWORK_DETAILS WatchWalletChanges.fetchInfo() calls REQUEST_PUBLIC_KEY then REQUEST_NETWORK_DETAILS sequentially. Responding to both immediately caused the watcher callback to fire on mount (address changed from "" → mockAddress), auto-connecting the wallet before the test could click "Connect Wallet". By not responding to REQUEST_NETWORK_DETAILS the watcher hangs at the second await and never fires its callback. Explicit connect() only sends REQUEST_PUBLIC_KEY so it is unaffected. All beforeEach setups can now find and click the button. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…chars - TokenDashboard: add token-list-container class to outer div so the E2E dashboard test can locate the element via CSS selector - WalletButton: truncate with end=6 so the last 6 chars of the connected address are visible, matching what auth.spec.ts expects via substring(48) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
frontend/src/utils/logger.ts— a thin wrapper that callsconsole.errorin dev and silences output in production (ready to forward to Sentry when integrated)console.errorinTokenCreateForm.tsx(deployment errors) andWalletContext.tsx(balance fetch + connection check) withlogger.errorCloses #848
Test plan