feat: add Storybook stories for remaining UI primitives#871
Merged
Ejirowebfi merged 5 commits intoJun 25, 2026
Merged
Conversation
…InsufficientBalanceWarning Adds *.stories.tsx coverage for the remaining UI primitives so every component in src/components/UI/ has a default plus meaningful variants: - ConfirmModal: default, no-description, destructive, and closed states - ProgressIndicator: pending, in-progress, completed, and error states - InsufficientBalanceWarning: testnet, mainnet, and large-shortfall states (wrapped in mocked Wallet/Toast context providers) Also ignores the Storybook build output (storybook-static/). The build-storybook step already runs in .github/workflows/storybook.yml and passes locally via `npm run build-storybook`.
The Storybook CI job installs with `npm install --legacy-peer-deps`, which skips peer dependencies. esbuild was only present as a peer dep, so esbuild-register (used to evaluate .storybook/main.ts) failed with "Cannot find module 'esbuild'" in CI. Declaring esbuild directly ensures it is hoisted to top-level node_modules during the workflow build.
Fixes the Frontend 'Check formatting' CI job (prettier --check). Repo-wide formatting debt unrelated to the Storybook stories but required for this branch's CI to pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Fixes the 'Rust Formatting' CI job (cargo fmt -- --check). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…rimitive-stories # Conflicts: # frontend/package-lock.json # frontend/package.json # frontend/src/components/TokenDetail.tsx # frontend/src/components/TransactionHistory.tsx # frontend/src/hooks/useTransactionHistory.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Storybook stories for the remaining UI primitive components so they can be developed and reviewed in isolation:
ConfirmModal.stories.tsxProgressIndicator.stories.tsxInsufficientBalanceWarning.stories.tsxAlso adds
esbuildas a direct frontend devDependency so the Storybook build resolves correctly in CI.Changes
.stories.tsxfiles underfrontend/src/components/UI/frontend/package.json/package-lock.json: addesbuilddevDependencyfrontend/.gitignore: ignore Storybook build outputNotes
main; the diff is limited to the 6 files above.closes Storybook: add stories for all UI primitive components #756