Fix for #615: Use ValueInstantiators to rename creator properties so they match property definitions by mcvayc · Pull Request #806 · FasterXML/jackson-dataformat-xml

mcvayc · 2026-03-15T01:29:14Z

Hi,

This PR was intended to fix #615 but in the process tests for #149, #517, #735, #795 in the tofix package started passing as well. I've listed all the issues for which test are now passing in the commits, but still need to verify for those that the entire issue is fixed.

The initial solution was co-written by Claude Code and me. After collaboratively creating a fix, I subsequently read through the code and edited it for quality and consistency. I believe the solution is now in decent shape, at least for #615.

Please let me know what you think. I'm happy to make further edits.

mcvayc · 2026-03-15T01:34:27Z

src/main/java/tools/jackson/dataformat/xml/deser/XmlValueInstantiators.java

+            // Second check: rename map from property definitions
+            String newName = renames.get(propName);
+            if (newName != null && !newName.equals(propName)) {
+                creatorProps[i] = prop.withSimpleName(newName);


Other than directly editing the array items, is there a better way to update the creator properties of the instantiator? I didn't see a setter.

That does seem dangerous. Ideally would not tweak internal data structures nor have setters but create new instances.

I'll have to think about this one.

I added a proposed improvement in the latest commit. This is safer but less performant, since we copy the array even if there is no need. Another option would be to only copy the array after we identify the first rename, but then we need to check if the array is not null each time that we rename.

I think this is acceptable: this does not occur for every read but only when deserializer is constructed.

mcvayc · 2026-03-15T01:37:11Z

src/test/java/tools/jackson/dataformat/xml/tofix/XmlTextViaCreator306Test.java

-    // [dataformat-xml#423]
-    @JacksonTestFailureExpected
-    @Test
-    public void testXmlTextViaCtor423() throws Exception


This test started passing so I split it out so it could be removed from the tofix package.

The test now resides in src/test/java/tools/jackson/dataformat/xml/deser/XmlTextViaCtor423Test.java

mcvayc · 2026-03-15T22:17:32Z

I see the build errors, let me take a look.

…ame creator properties so they match property definitions

…is found.

mcvayc · 2026-03-15T22:37:25Z

Sorry about that. I somehow missed adding a module file to the commit.

I've rebased and confirmed that everything is passing on my end.

[INFO] --- jacoco:0.8.14:report (report) @ jackson-dataformat-xml ---
[INFO] Loading execution data file C:\Users\chips\Documents\GitHub\mcvayc\jackson-dataformat-xml\target\jacoco.exec
[INFO] Analyzed bundle 'Jackson-dataformat-XML' with 53 classes
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  15.826 s
[INFO] Finished at: 2026-03-15T18:36:53-04:00
[INFO] ------------------------------------------------------------------------

mcvayc · 2026-03-15T22:47:05Z

Additionally, since the rebase it looks like test #795 now also passes so I've also moved that one out of tofix.

src/main/java/tools/jackson/dataformat/xml/deser/XmlValueInstantiators.java

src/main/java/tools/jackson/dataformat/xml/JacksonXmlAnnotationIntrospector.java

github-actions · 2026-03-15T23:13:47Z

🧪 Code Coverage Report

Metric	Coverage	Change
Instructions	71.13%	📈 +0.660%
Branches	65.50%	📈 +0.210%

Coverage data generated from JaCoCo test results

github-actions · 2026-03-16T01:07:07Z

🧪 Code Coverage Report

Metric	Coverage	Change
Instructions	71.20%	📈 +0.730%
Branches	65.48%	📈 +0.190%

Coverage data generated from JaCoCo test results

github-actions · 2026-03-16T01:12:53Z

🧪 Code Coverage Report

Metric	Coverage	Change
Instructions	71.22%	📈 +0.720%
Branches	65.76%	📈 +0.180%

Coverage data generated from JaCoCo test results

github-actions · 2026-03-16T01:30:43Z

🧪 Code Coverage Report

Metric	Coverage	Change
Instructions	71.22%	📈 +0.720%
Branches	65.76%	📈 +0.180%

Coverage data generated from JaCoCo test results

cowtowncoder

LGTM!

mcvayc · 2026-03-16T01:31:50Z

LGTM!

Thank you! I found one more optimization I'd like to push.

github-actions · 2026-03-16T01:32:07Z

🧪 Code Coverage Report

Metric	Coverage	Change
Instructions	71.21%	📈 +0.710%
Branches	65.83%	📈 +0.250%

Coverage data generated from JaCoCo test results

cowtowncoder · 2026-03-16T01:32:26Z

@mcvayc This looks very good -- thank you for contributing it! I'll add release notes and merge it for inclusion in 3.2.0!

cowtowncoder · 2026-03-16T01:32:59Z

LGTM!

Thank you! I found one more optimization I'd like to push.

Ok I'll wait after updating release notes.

mcvayc · 2026-03-16T01:34:58Z

LGTM!

Thank you! I found one more optimization I'd like to push.

Ok I'll wait after updating release notes.

Never mind, you beat me to it with your streamlining commit. :-)

I was going to delay the array copy.

cowtowncoder · 2026-03-16T01:52:56Z

@mcvayc Ok; good to, will merge. Looks like #306 is still partially failing, but fixing 5 issues is a pretty big achievement!

github-actions · 2026-03-16T01:53:15Z

🧪 Code Coverage Report

Metric	Coverage	Change
Instructions	71.21%	📈 +0.710%
Branches	65.83%	📈 +0.250%

Coverage data generated from JaCoCo test results

cowtowncoder · 2026-03-16T02:05:40Z

@mcvayc Ok; good to, will merge. Looks like #306 is still partially failing, but fixing 5 issues is a pretty big achievement!

I am working on #306 -- test is buggy.

mcvayc · 2026-03-16T02:09:23Z

@mcvayc Ok; good to, will merge. Looks like #306 is still partially failing, but fixing 5 issues is a pretty big achievement!

I am working on #306 -- test is buggy.

Makes sense.

Thanks for all that you do for the Jackson projects and for being so supportive of contributions.

cowtowncoder · 2026-03-16T02:15:31Z

Thanks for all that you do for the Jackson projects and for being so supportive of contributions.

Thank you for the kind words. It is good to get feedback like this.

And thank you for providing the fixes here!

mcvayc commented Mar 15, 2026

View reviewed changes

mcvayc force-pushed the fix/issue-615 branch 2 times, most recently from 8b1cbb5 to c9b82bb Compare March 15, 2026 22:25

mcvayc added 2 commits March 15, 2026 18:36

Fixes FasterXML#149, FasterXML#517, FasterXML#735, FasterXML#795: Ren…

6f2c000

…ame creator properties so they match property definitions

Fixes FasterXML#615: Wrap XML text value when no default constructor …

347c249

…is found.

mcvayc force-pushed the fix/issue-615 branch from c9b82bb to 347c249 Compare March 15, 2026 22:36

cowtowncoder added the cla-received PR already covered by CLA (optional label) label Mar 15, 2026

cowtowncoder reviewed Mar 15, 2026

View reviewed changes

src/main/java/tools/jackson/dataformat/xml/deser/XmlValueInstantiators.java Outdated Show resolved Hide resolved

cowtowncoder reviewed Mar 15, 2026

View reviewed changes

src/main/java/tools/jackson/dataformat/xml/deser/XmlValueInstantiators.java Outdated Show resolved Hide resolved

Remove check since it should never happen and it's an error if it does.

1d67507

cowtowncoder reviewed Mar 15, 2026

View reviewed changes

src/main/java/tools/jackson/dataformat/xml/JacksonXmlAnnotationIntrospector.java Outdated Show resolved Hide resolved

Simplify null-safe boolean check.

ccca584

mcvayc added 2 commits March 15, 2026 20:21

Use & instead of # for magic value.

c4503b7

A suggestion for a safer approach to creator property renames.

c594569

Merge branch '3.x' into fix/issue-615

b7238a3

cowtowncoder added 2 commits March 15, 2026 18:28

Minor streamlining

a0ef17b

minor streamlining

63d426c

cowtowncoder approved these changes Mar 16, 2026

View reviewed changes

This was referenced Mar 16, 2026

@JacksonXmlElementWrapper as a @JsonCreator parameter not working #149

Closed

XML wrapper doesn't work with java records #517

Closed

Update release notes

f8034a9

This was referenced Mar 16, 2026

Java Record with @JacksonXmlText stopped working with 2.18 #735

Closed

HttpHeader object (= <httpHeaders>) is not wrapped by the XML <property> tag #795

Closed

cowtowncoder merged commit 7ebba38 into FasterXML:3.x Mar 16, 2026
3 checks passed

cowtowncoder added a commit that referenced this pull request Mar 16, 2026

Fix #306 test (actual fix via #806)

f482b5b

cowtowncoder added a commit that referenced this pull request Mar 16, 2026

Fix #306 test (actual fix via #806) (#810)

c405235

Uh oh!

Conversation

mcvayc commented Mar 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mcvayc Mar 15, 2026

Choose a reason for hiding this comment

Uh oh!

cowtowncoder Mar 15, 2026

Choose a reason for hiding this comment

Uh oh!

mcvayc Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cowtowncoder Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

mcvayc Mar 15, 2026

Choose a reason for hiding this comment

Uh oh!

mcvayc Mar 15, 2026

Choose a reason for hiding this comment

Uh oh!

mcvayc commented Mar 15, 2026

Uh oh!

mcvayc commented Mar 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mcvayc commented Mar 15, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 15, 2026

🧪 Code Coverage Report

Uh oh!

github-actions bot commented Mar 16, 2026

🧪 Code Coverage Report

Uh oh!

github-actions bot commented Mar 16, 2026

🧪 Code Coverage Report

Uh oh!

github-actions bot commented Mar 16, 2026

🧪 Code Coverage Report

Uh oh!

cowtowncoder left a comment

Choose a reason for hiding this comment

Uh oh!

mcvayc commented Mar 16, 2026

Uh oh!

github-actions bot commented Mar 16, 2026

🧪 Code Coverage Report

Uh oh!

cowtowncoder commented Mar 16, 2026

Uh oh!

cowtowncoder commented Mar 16, 2026

Uh oh!

mcvayc commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cowtowncoder commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 16, 2026

🧪 Code Coverage Report

Uh oh!

Uh oh!

cowtowncoder commented Mar 16, 2026

Uh oh!

mcvayc commented Mar 16, 2026

Uh oh!

cowtowncoder commented Mar 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

mcvayc commented Mar 15, 2026 •

edited

Loading

mcvayc Mar 16, 2026 •

edited

Loading

mcvayc commented Mar 15, 2026 •

edited

Loading

mcvayc commented Mar 16, 2026 •

edited

Loading

cowtowncoder commented Mar 16, 2026 •

edited

Loading