Add an overload to xxhash to allow it to take a string constant#189
Merged
TrentHouliston merged 4 commits intomainfrom Sep 3, 2025
Merged
Add an overload to xxhash to allow it to take a string constant#189TrentHouliston merged 4 commits intomainfrom
TrentHouliston merged 4 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where calling xxhash functions with string literals (e.g., xxhash32("Hello")) would only hash the first character instead of the entire string. The fix adds template overloads that correctly handle string literals by deducing the array size and excluding the null terminator.
- Added template overloads for both xxhash32 and xxhash64 to handle string literal arrays
- Modified existing template overloads to take references instead of pointers for better type safety
- Added comprehensive tests to verify string literals hash the same as explicit length calls
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/util/serialise/xxhash.hpp | Added string literal template overloads and modified existing templates to use references |
| tests/tests/util/serialise/xxhash.cpp | Added test scenarios for string literal functionality and updated namespace usage |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
People were using the xxhash function with string constants like
xxhash32("Hello");and it was compiling just fine, and then returning the hash of the first letter.This adds an overload which makes xxhash32("Hello"); use a template with an
Narray in order to hash that correctly.