Add non-blocking socket support and error handling in NUClearNetwork#187
Open
TrentHouliston wants to merge 2 commits intomainfrom
Open
Add non-blocking socket support and error handling in NUClearNetwork#187TrentHouliston wants to merge 2 commits intomainfrom
TrentHouliston wants to merge 2 commits intomainfrom
Conversation
This commit introduces a new function to set sockets to non-blocking mode and enhances error handling for network operations. Specifically, it throws exceptions for network errors during packet reception and sending, ensuring robust error management. The changes improve the reliability of the NUClearNetwork by preventing blocking behavior and handling potential errors gracefully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a new function to set sockets to non-blocking mode and enhances error handling for network operations. Specifically, it throws exceptions for network errors during packet reception and sending, ensuring robust error management. The changes improve the reliability of the NUClearNetwork by preventing blocking behavior and handling potential errors gracefully.