Return object response data after login - #10
Open
albanafmeti wants to merge 1 commit into
Open
albanafmeti wants to merge 1 commit into
albanafmeti wants to merge 1 commit into
Conversation
Why returning `true` when somebody may need more information for example `authToken` ? The returned object is different from `false` so I think it will be fine returning the object `$response->body->data`.
Owner
|
Thanks for collaborating @albanafmeti ! Doing this will ship the auth token automatically with following requests, so you don't have to worry about it. If you need the auth token outside the login method, you can get it from the Request : |
Author
|
Check this out https://github.com/albanafmeti/rocket-chat |
nelsonko
added a commit
to nelsonko/rocket-chat-rest-client
that referenced
this pull request
Aug 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why returning
truewhen somebody may need more information for exampleauthToken?The returned object is different from
falseso I think it will be fine returning the object$response->body->data.