Skip to content

Limit range of identifiers#276

Merged
kleihan merged 2 commits intov1-1-RC3from
limit-id-range
Feb 25, 2026
Merged

Limit range of identifiers#276
kleihan merged 2 commits intov1-1-RC3from
limit-id-range

Conversation

@kleihan
Copy link
Member

@kleihan kleihan commented Feb 12, 2026

Fixes #265

@kleihan kleihan requested a review from patricklucas February 12, 2026 17:06
@patricklucas
Copy link
Collaborator

As discussed offline, the issue appears to be that, due to now restricting IDs to the range of a Java int, the JAXB codegen now uses int instead of BigInteger for ID properties in generated classes.

The two solutions are to either configure the codegen to continue to use BigInteger, or to update the two classes in this repo that expect BigInteger to expect int instead.

I don't have insight into how many users this library has who might be affected by the change to int. However, we are already making breaking changes to the schema (and thus the codegen) which would require users to make code changes, so I don't think the change to int adds a significant burden beyond that.

@kleihan I have a commit prepared to change BigInteger references to int that I can add to this PR if you wish.

@kleihan kleihan merged commit c25ef5c into v1-1-RC3 Feb 25, 2026
2 checks passed
@kleihan kleihan deleted the limit-id-range branch February 25, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants