Conversation
|
Running with |
schnellerhase
left a comment
schnellerhase
left a comment
There was a problem hiding this comment.
Add the flags to generate-cmakefiles.py and regenerate, for the same behaviour on the C++ demos?
| # Nicer stack traces | ||
| check_cxx_compiler_flag("-fno-omit-frame-pointer" HAVE_NO_OMIT_FRAME_POINTER) | ||
| if(HAVE_NO_OMIT_FRAME_POINTER) | ||
| list(APPEND DOLFINX_CXX_DEVELOPER_FLAGS -fno-omit-frame-pointer) | ||
| endif() | ||
|
|
||
| # Add fast memory error detector | ||
| check_cxx_compiler_flag("-fsanitize=address" HAVE_ADDRESS_SANITIZER) | ||
| if(HAVE_ADDRESS_SANITIZER) | ||
| list(APPEND DOLFINX_CXX_DEVELOPER_FLAGS -fsanitize=address) | ||
| list(APPEND DOLFINX_LINK_DEVELOPER_FLAGS -fsanitize=address) | ||
| endif() | ||
|
|
There was a problem hiding this comment.
We should think about a nicer way to maintain these centrally and not twice in cpp and cpp/test.
There was a problem hiding this comment.
We should probably write one or more CMakePreset.json file, e.g.: https://cmake.org/cmake/help/latest/manual/cmake-presets.7.html and remove this.
There was a problem hiding this comment.
Or/plus a toolchain file:
https://cmake.org/cmake/help/latest/manual/cmake-toolchains.7.html
There was a problem hiding this comment.
Not sure actually, an include looks simplest.
There was a problem hiding this comment.
I'd go with include as well. Maybe we can also export it through the install of dolfinx? For both the standalone tests and the demos we require anyways the presence of a dolfinx install, so we could inherit the flags from that one, needs to be exported in that case.
2 participants
No description provided.