Open
Conversation
Collaborator
|
This looks great so far. Let me know if you'd like me to approve and merge into master if that's helpful |
SachinMeier
reviewed
Mar 13, 2023
| priv | ||
|
|
||
| /client/oracle_client/burrito_out/ | ||
| .tool-versions |
Collaborator
There was a problem hiding this comment.
It might be good if we set a specific elixir and erlang version
Author
There was a problem hiding this comment.
I have the same versions, Elixir 14 and Erlang 25, but I use asdf so I have problems by running the application. I modified the tools but I set it into the gitignore for not giving you problems.
Collaborator
There was a problem hiding this comment.
ok, I'm ok including the .tool-versions though if you want. I use asdf as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I create some extra modules, Debug module for development and test and Schema module for the different schema definitions, also y test the debug module.