Skip to content

Hide reporting implementation from the EventViewerX 4.0 API - #259

Merged
PrzemyslawKlys merged 3 commits into
masterfrom
refactor/eventviewerx-public-api
Aug 16, 2026
Merged

Hide reporting implementation from the EventViewerX 4.0 API#259
PrzemyslawKlys merged 3 commits into
masterfrom
refactor/eventviewerx-public-api

Conversation

@PrzemyslawKlys

Copy link
Copy Markdown
Member

Summary

  • make all existing EventViewerX.Reports.* executors, builders, contracts, rows, aggregators, and correlation helpers internal
  • keep the supported C# query surface public through EventLogEngine, EventQueryDefinition, NamedEventEngine, NamedEventQuery, and NamedEvents
  • add an assembly-level contract test that prevents reporting implementation types from becoming exported again
  • remove the PowerShell test that bypassed the cmdlet surface to instantiate a reporting executor directly

Breaking change

EventViewerX.Reports.* is no longer part of the EventViewerX 4.0 public API. The implementation remains in the assembly for internal validation and later extraction, but C# consumers cannot compile against those types.

A known IntelligenceX source consumer currently uses these report executors directly and must be migrated as part of the subsequent reporting design. This change intentionally does not add an EventViewerX.Reporting package or new reporting API.

Validation

  • cross-target solution build succeeded for net472, net8, and net10 with zero warnings or errors
  • 708/708 EventViewerX tests passed on both net8 and net10
  • the PowerShell 7 suite passed 184 tests and the Windows PowerShell 5.1 suite passed 181 tests
  • PowerForge produced the NuGet and PowerShell artifacts; both export zero EventViewerX.Reports.* types while the module still exposes 26 cmdlets and 3 aliases
  • independent local review found no actionable findings

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@PrzemyslawKlys
PrzemyslawKlys merged commit e2367c9 into master Aug 16, 2026
4 checks passed
@PrzemyslawKlys
PrzemyslawKlys deleted the refactor/eventviewerx-public-api branch August 16, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant