Return all PowerShell query rows by default - #227
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #227 +/- ##
==========================================
+ Coverage 53.08% 53.27% +0.18%
==========================================
Files 261 261
Lines 19727 19740 +13
Branches 3414 3415 +1
==========================================
+ Hits 10472 10516 +44
+ Misses 8239 8209 -30
+ Partials 1016 1015 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b42a310b74
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PSObject-ReturnType DataRow,DataTable, and reader modes availablePS*column aliases asColumn_<name>and add numeric suffixes when needed, so unusual schemas do not drop query resultsCompatibility
This intentionally changes the default output shape from
DataRowtoPSObject. Scripts that require the legacy object type can continue to use-ReturnType DataRow(or-As DataRow) explicitly.Ordinary SQL aliases are preserved. Because PowerShell reserves the
PS*member namespace, a source alias such asPSObjectis exposed asColumn_PSObject; if that name already exists, DbaClientX selects the next numeric suffix without hiding either value.Validation
PSCustomObjectvalues in PowerShell 7 and Windows PowerShell 5.1