Toll Fee calculation done in Node Js - #100
Open
karthick-krishnan wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Team,
This is Karthick Krishnan. I have done the Toll fee calculation in Node Js. Please do check it out. Hopefully we can have a chat soon regarding this. I have made some small changes in the logic of the calculation and made changes in getting the toll fee for each hour dynamically. I have added Unit test cases. I believe i have covered all the scenarios. I firmly believe that when a functionality is unit tested thoroughly with full coverage results then only its production ready. I have made my part as a production ready code please do check and let me know if i have to make any changes. I am listing the commands to run and the screenshot of the unit cases results coverage report below.
The movie name in the GIF is Hackers :)
Installation Requirements
node js
npm
jest
Commands to run the test cases:
npm install
npm run test