fix(ui-web): say a failed connect or test under the agent, not instead of it

[arelchan]

Summary

The agent connector (Settings > Agent connections, and the onboarding agents step) is reworked around what goes wrong on it. Frontend only: no RPC change, and every word drawn comes from fields subagents.* already sends (data.detail and data.remedy on a refused write, last_test_* on a row).

A failure is said under the agent, not instead of it. A refused connect or a failed test used to replace the line about the agent with a red sentence, and a card or sheet grew to fit it. Now:

• Every card is one fixed shape: the name, two lines of room for what the agent does, and a slot that always speaks. With nothing wrong the slot is a quiet grey word for the row's state (connected, available, not installed, a caveat, and when a passed test passed). A refused write or a failed test fills it with a single-line clay strip: one word for what failed, a short reason read off remedy.kind (every kind, including the ones fix(*): a refused Qwen Code connect names the fix and the command #779, fix(*): a Qwen Code on an old Node.js names it, and its model fix runs /auth #786 and fix(*): a refused Kimi Code connect says why and names the fix #781 added), or "see why" when there is none. A write in flight fills it in amber. Cards measured at one height across every state.
• The press that answers a strip is the card's corner control, where connect and install already live (retry after a refusal, retest after a failed test on a connected row). The strip carries no button.
• The sheet keeps its fixed 520x500 box. Its head says only which state (the dot and line read fix(ui-web): re-probe after a write, and read one health verdict in the agent card and sheet #773's healthOf); the why and the how are a note at the top of the body that scrolls with it: a title per remedy kind, FIX_SAY's sentence, the command (or fix(*): a refused Qwen Code connect names the fix and the command #779's two numbered steps when remedy.then is set), and the server's sentence folded under it. Without a remedy the server's sentence is shown as it came, since it is the only reason there is.
• The wizard's rows open no sheet, so their second line carries the step: the short reason, then the command as code, with then as a second piece of code; "run it to see why" for network, silent and config; and "open it in a browser" for a plan, whose command is the page that sells one.

Waiting. Before the first roster arrives the grid draws one placeholder card per catalogue entry (the catalogue is the roster on every machine), with the settings sections' shimmer; the tab counts wait as bars rather than showing 0. The shimmer gate now covers these bars too.

Agent marks in the dark theme. Every mark now sits on a light plate in both themes, as the app icon does, and no filter reaches a mark. Inverting hermesagent.svg gave its negative, and the hue rotation that put qoder's green back landed on a different green (#2ADB5C -> #008203). The plate is a token (--mark-plate) declared by every theme block, and the embedded color-scheme is pinned light on the tile, so raven.svg and miromind.svg draw their light selves on it. agent-mark-css.test.mjs is rewritten to pin that: no filter on a mark, the plate token in every theme path, the scheme pinned on the tile and not on :root.

Copy. The general settings' language hint now says it picks the interface's language rather than Raven's.

Rebased onto #773, #779, #786 and #781, which touch the same files. #773's healthOf stays the one verdict for the dot and the sheet's head; the card's footer and corner, and the sheet's note, are this change's. #773's rule that an off row wears no dot for a failed test is kept; its footer still says so. #779's FIX_SAY table and step labels feed the note, with #786's remedy passed through so the runtime sentence names both Node.js versions; a runtime fix sent without them reads as a launch that quit in the title and on the card too (kindOf), as FIX_SAY already says it; its row sentences (bad_run*, bad_retry, bad_open) and the fix_unknown_* keys have no caller left and are removed.

Earlier decisions this changes, for their authors to confirm:

• Dark-theme agent marks (@LivXue's filters, @0xKT's gate in refactor(ui-web): dissolve shell, layer state and render the last writers from stores #478, whose note says neither filter may become a blanket rule): the filters are gone and every mark sits on the plate instead. This reaches every .agent-mark tile on the page, not only the connector.
• A refusal with no remedy (@Handsome-wzw, fix(*): show a failed connect's fix in the reader's language, with its command to copy #730 / fix(*): name a failed connect in the reader's words, and give npx time for a first download #754): the server's sentence was folded because, shown first, it was a red English paragraph. Here it is shown as it came when there is no remedy, since it is then the only reason there is; with a remedy it stays folded.
• An off row whose last test failed (@0xKT, fix(ui-web): re-probe after a write, and read one health verdict in the agent card and sheet #773): it still wears no dot, but the card's footer says the test failed.
• Where the fix is said in the sheet (@Handsome-wzw fix(*): show a failed connect's fix in the reader's language, with its command to copy #730, @0xKT fix(ui-web): re-probe after a write, and read one health verdict in the agent card and sheet #773): moved from the head's status line to a note at the top of the body. The head's caveat line for a connected row is unchanged, and still folds the probe's words under it.
• The card and wizard-row failure text (@Handsome-wzw, fix(*): name a failed connect in the reader's words, and give npx time for a first download #754 / fix(*): a refused Qwen Code connect names the fix and the command #779 / fix(*): a refused Kimi Code connect says why and names the fix #781): the line about the agent stays and the failure is a footer under it; the row's commands are code inside the sentence. The sentences keep fix(*): a refused Qwen Code connect names the fix and the command #779's content. One change of reading: a config row says to run kimi doctor config to see where the file is wrong (as fix(*): a refused Kimi Code connect says why and names the fix #781's sheet sentence does), where fix(*): a refused Kimi Code connect says why and names the fix #781's row said to run it and retry.

Review follow-up. The failed-test note named Test for every row that was not connected, but the sheet's bar offers Test only to an unauthorized row; a row whose test has since cleared its handshake, and an endpoint still waiting on its key, show Connect alone. The note now reads its press from the same branches as the bar (testPress), and a test walks every state a failed test can leave a row in and checks the note names a button the bar renders. The endpoint test that expected Test for a row waiting on its key now expects Connect.

Type

• Fix
• Feature
• Docs
• CI / tooling
• Refactor
• Other

Verification

After the rebase onto main at 05cac1f1:

• npx vitest run --maxWorkers=4 in ui-web -- 210 files, 3055 tests passed; the extAgents suites and page gates alone (npx vitest run src/features/extAgents scripts/gates) 385 tests

• npx tsc --noEmit -p . and npm run lint in ui-web -- 0 errors (the 4 warnings main already has)

• node scripts/check-css.mjs, node scripts/check-class-namespace.mjs, npm run build && python3 build.py && node scripts/check-page.mjs in ui-web -- OK

• npm run gen:check in ui-web -- generated.ts matches the contract

• npm run gen:i18n and npm run lint:i18n in ui-tui -- the generated table is up to date

• uv run pytest tests/test_ui_agent_marks.py -q -- 7 passed

• Real browser (Playwright on the Vite dev page, zh and en, light and dark), with failure states injected from backend-shaped fixtures (sign_in, setup, api_key, download, and model with a then step; the unit tests take every kind): all 11 cards 149px tall across healthy, testing and failed states and in the placeholder grid; the sheet 520x500 for 7 rows in different states; a click on the corner retry does not open the sheet

• Against a live gateway (Vite dev server proxying /auth to it): the real 18-row roster renders with the new footer and plate

• Relevant tests pass locally

• Relevant lint / type checks pass locally

• User-facing docs or screenshots are updated when needed

No user-facing docs describe the agent cards.

Risk

• Security impact considered
• Backward compatibility considered
• Rollback path is clear for risky changes

User-visible: the card and sheet layout for failures, the corner control now also retries and retests, the waiting grid, and every agent mark sits on a light plate in the dark theme (a visible change to all mark tiles there, including the sub-agents card and pane headers that share .agent-mark). No RPC, config or stored-state change; reverting the squash commit restores the previous page.

Related Issues

N/A

[gloryfromca]

Blocking: the failed-test note can direct the user to a button that is not present.

I found one actionable state mismatch inline. I reviewed the full diff and relevant extAgents rendering, store/source state transitions, callers, recent history, compatibility behavior, and the repository rules in AGENTS.md, CONTEXT-MAP.md, and ui-web/CONTEXT.md. I also checked that the changed tests preserve the existing behaviors rather than weakening them.

Verification: npm run type-check passed; the focused extAgents/CSS suite passed (117 tests); the full npm test suite passed (210 files, 3037 tests); npm run lint completed with no errors and four pre-existing warnings in untouched files.

[gloryfromca]

Blocking: the existing failed-test note/action mismatch remains unchanged.

The rebase compatibility work for the new runtime remedy is coherent, but the open finding still reproduces: after the test case clears needs_auth while leaving the row unconfigured and failed, noteOf names Test while AgentSheet renders Connect. I found no additional blocker in this revision, and the original thread remains open.

I reviewed the fresh github/main...HEAD diff, the rebase delta, the extAgents state/action callers, the new remedy compatibility path, recent history, backward compatibility, test changes, and the applicable AGENTS.md and Web UI context constraints.

Verification: npm run type-check passed; the focused extAgents and CSS suite passed (6 files, 169 tests); the full npm test suite passed (210 files, 3041 tests).

[gloryfromca]

No blockers; this can merge as far as I am concerned.

The action-label mismatch is fixed: the note now follows the same state branches as the sheet action bar, and the regression test covers the original transition plus connected, unauthorized, available, and key-waiting rows. I replied to and resolved my finding thread.

I reviewed the updated github/main...HEAD diff, the new commit, the affected state/action callers, compatibility behavior, test changes, and the previously covered repository and Web UI constraints. No new finding survived review.

Verification: npm run type-check passed; the focused extAgents and CSS suite passed (6 files, 181 tests).