Skip to content

fix(ui-web): drop the note beside tool_search on the tools page - #561

Merged
0xKT merged 1 commit into
refactor/ui_web_architecturefrom
fix/ui_web_drop_tool_search_note
Sep 20, 2026
Merged

0xKT merged 1 commit into
refactor/ui_web_architecturefrom
fix/ui_web_drop_tool_search_note

Conversation

@gloryfromca

Copy link
Copy Markdown
Member

Summary

The tools page drew a note beside tool_search reading "switched on by the tool-search setting, not here" (and its zh sentence). The owner asked for it to go. The key leaves the shared catalogue i18n/messages.json, the TUI copy ui-tui/src/i18n/messages.generated.ts is regenerated from it (npm run gen:i18n), the style rule only this note used goes with it, and the page test no longer looks for the note. The row's switch stays the fixed, disabled control it was.

Type

  • Fix
  • Feature
  • Docs
  • CI / tooling
  • Refactor
  • Other

Verification

cd ui-web && npx vitest run src/features/settings/pages/Tools.test.tsx scripts/gates/i18n-keys.test.mjs scripts/gates/css-balance.test.mjs scripts/gates/css-one-owner.test.mjs scripts/gates/check-css.test.mjs
Test Files  5 passed (5)
Tests  22 passed (22)

cd ui-web && npx eslint src/features/settings/pages/Tools.tsx src/features/settings/pages/Tools.test.tsx
(clean)

cd ui-web && npx tsc --noEmit -p .
(exit 0)

cd ui-tui && npm run lint:i18n
i18n: generated catalogue is up to date

No screenshot: the change removes one span, and the page test renders the row.

  • Relevant tests pass locally
  • Relevant lint / type checks pass locally
  • User-facing docs or screenshots are updated when needed

Risk

  • Security impact considered: none, copy removal only.
  • Backward compatibility considered: no RPC or config shape changes.
  • Rollback path is clear for risky changes: revert the commit.

Related Issues

N/A

The row carried "switched on by the tool-search setting, not here"; the
owner asked for it to go. The key leaves the shared catalogue and the
TUI copy is regenerated from it; the style that only this note used goes
with it.

Co-authored-by: Claude (claude-fable-5-1) <noreply@anthropic.com>

@gloryfromca gloryfromca left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blockers; this can merge as far as I am concerned.

Reviewed the five-file change against the PR's actual base commit. The note, its dedicated test assertion, its now-unused CSS rule, and both source/generated catalogue entries are removed consistently. The remaining tools-page test still covers the tool_search row's fixed disabled switch and its off state, so the test was narrowed with the intended UI behavior rather than weakened around unrelated behavior.

Coverage included AGENTS.md/CLAUDE.md and the Web UI context/conventions, the complete diff, the rendering and i18n consumers, the history that introduced the note, backward compatibility, test intent, and the UI architecture boundaries. There are no RPC or config changes, new imports, cross-domain edges, or stale references.

Verification:

  • cd ui-web && npm test: 186 files passed, 2,544 tests passed
  • cd ui-web && npm run type-check: passed
  • cd ui-web && npm run lint: passed with 5 pre-existing hook warnings and 0 errors
  • cd ui-web && npm run gen:check: passed
  • cd ui-tui && npm run lint:i18n: passed
  • git diff --check: passed

@0xKT
0xKT merged commit 6062b36 into refactor/ui_web_architecture Sep 20, 2026
21 checks passed
@0xKT
0xKT deleted the fix/ui_web_drop_tool_search_note branch September 20, 2026 14:45
gloryfromca added a commit that referenced this pull request Sep 21, 2026
## Summary

The tools page drew a note beside `tool_search` reading "switched on by
the tool-search setting, not here" (and its zh sentence). The owner
asked for it to go. The key leaves the shared catalogue
`i18n/messages.json`, the TUI copy
`ui-tui/src/i18n/messages.generated.ts` is regenerated from it (`npm run
gen:i18n`), the style rule only this note used goes with it, and the
page test no longer looks for the note. The row's switch stays the
fixed, disabled control it was.

## Type

- [x] Fix
- [ ] Feature
- [ ] Docs
- [ ] CI / tooling
- [ ] Refactor
- [ ] Other

## Verification

```
cd ui-web && npx vitest run src/features/settings/pages/Tools.test.tsx scripts/gates/i18n-keys.test.mjs scripts/gates/css-balance.test.mjs scripts/gates/css-one-owner.test.mjs scripts/gates/check-css.test.mjs
Test Files  5 passed (5)
Tests  22 passed (22)

cd ui-web && npx eslint src/features/settings/pages/Tools.tsx src/features/settings/pages/Tools.test.tsx
(clean)

cd ui-web && npx tsc --noEmit -p .
(exit 0)

cd ui-tui && npm run lint:i18n
i18n: generated catalogue is up to date
```

No screenshot: the change removes one span, and the page test renders
the row.

- [x] Relevant tests pass locally
- [x] Relevant lint / type checks pass locally
- [ ] User-facing docs or screenshots are updated when needed

## Risk

- [x] Security impact considered: none, copy removal only.
- [x] Backward compatibility considered: no RPC or config shape changes.
- [x] Rollback path is clear for risky changes: revert the commit.

## Related Issues

N/A

Co-authored-by: gloryfromca <23442919+gloryfromca@users.noreply.github.com>
Co-authored-by: Claude (claude-fable-5-1) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants