Repository navigation
fix(ui-web): drop the note beside tool_search on the tools page - #561
Conversation
The row carried "switched on by the tool-search setting, not here"; the owner asked for it to go. The key leaves the shared catalogue and the TUI copy is regenerated from it; the style that only this note used goes with it. Co-authored-by: Claude (claude-fable-5-1) <noreply@anthropic.com>
gloryfromca
left a comment
There was a problem hiding this comment.
No blockers; this can merge as far as I am concerned.
Reviewed the five-file change against the PR's actual base commit. The note, its dedicated test assertion, its now-unused CSS rule, and both source/generated catalogue entries are removed consistently. The remaining tools-page test still covers the tool_search row's fixed disabled switch and its off state, so the test was narrowed with the intended UI behavior rather than weakened around unrelated behavior.
Coverage included AGENTS.md/CLAUDE.md and the Web UI context/conventions, the complete diff, the rendering and i18n consumers, the history that introduced the note, backward compatibility, test intent, and the UI architecture boundaries. There are no RPC or config changes, new imports, cross-domain edges, or stale references.
Verification:
cd ui-web && npm test: 186 files passed, 2,544 tests passedcd ui-web && npm run type-check: passedcd ui-web && npm run lint: passed with 5 pre-existing hook warnings and 0 errorscd ui-web && npm run gen:check: passedcd ui-tui && npm run lint:i18n: passedgit diff --check: passed
## Summary The tools page drew a note beside `tool_search` reading "switched on by the tool-search setting, not here" (and its zh sentence). The owner asked for it to go. The key leaves the shared catalogue `i18n/messages.json`, the TUI copy `ui-tui/src/i18n/messages.generated.ts` is regenerated from it (`npm run gen:i18n`), the style rule only this note used goes with it, and the page test no longer looks for the note. The row's switch stays the fixed, disabled control it was. ## Type - [x] Fix - [ ] Feature - [ ] Docs - [ ] CI / tooling - [ ] Refactor - [ ] Other ## Verification ``` cd ui-web && npx vitest run src/features/settings/pages/Tools.test.tsx scripts/gates/i18n-keys.test.mjs scripts/gates/css-balance.test.mjs scripts/gates/css-one-owner.test.mjs scripts/gates/check-css.test.mjs Test Files 5 passed (5) Tests 22 passed (22) cd ui-web && npx eslint src/features/settings/pages/Tools.tsx src/features/settings/pages/Tools.test.tsx (clean) cd ui-web && npx tsc --noEmit -p . (exit 0) cd ui-tui && npm run lint:i18n i18n: generated catalogue is up to date ``` No screenshot: the change removes one span, and the page test renders the row. - [x] Relevant tests pass locally - [x] Relevant lint / type checks pass locally - [ ] User-facing docs or screenshots are updated when needed ## Risk - [x] Security impact considered: none, copy removal only. - [x] Backward compatibility considered: no RPC or config shape changes. - [x] Rollback path is clear for risky changes: revert the commit. ## Related Issues N/A Co-authored-by: gloryfromca <23442919+gloryfromca@users.noreply.github.com> Co-authored-by: Claude (claude-fable-5-1) <noreply@anthropic.com>
Summary
The tools page drew a note beside
tool_searchreading "switched on by the tool-search setting, not here" (and its zh sentence). The owner asked for it to go. The key leaves the shared cataloguei18n/messages.json, the TUI copyui-tui/src/i18n/messages.generated.tsis regenerated from it (npm run gen:i18n), the style rule only this note used goes with it, and the page test no longer looks for the note. The row's switch stays the fixed, disabled control it was.Type
Verification
No screenshot: the change removes one span, and the page test renders the row.
Risk
Related Issues
N/A