Repository navigation
Conversation
… add inspection tools - trimd: Guard AVX/AVX2/AVX512/FMA3/F16C with OSXSAVE and XCR0 verification to prevent illegal instruction crashes (0xC000001D) on hypervisors and VMs - riglogic: Include spyus/CharPtr.i in RigLogic.i to prevent NULL-dereference segfaults when None is passed to string parameters - dna: Harden FilteredBinaryInputArchive bounds checks in processSubset, removeByIndex, and RawVertexSkinWeights against malformed stream corruption - dna: Optimize CoordinateSystemConverter to avoid redundant O(N * cols) writes of newOutputIndices on each column - ml: Provide complete generic vector templates for SigmoidActivationFunction and TanHActivationFunction across all SIMD widths - rbf: Vectorize and unroll dot products in InterpolativeRBFSolver; widen RBFSolver loop counter to size_t to prevent truncation - python: Enforce utf-8 encoding in insert_copyright.py to prevent Windows charmap decode errors - tools: Add missing tools/CMakeLists.txt, DnaInfo C++ CLI, and standalone pure-Python dna_tool.py inspector Signed-off-by: Koray Tasan <korrayt@users.noreply.github.com>
|
Hi @korrayt, thanks for taking the time to go through the codebase and for the detailed PR. I've reviewed each change. What we could take
What we can't merge, and why
Contribution processPlease have a look at
I'll close this PR once the detection fix, the skin-weights fix and the UTF-8 change have landed, and I'll link the commits and issues here so the credit stays attached to your findings. If you'd like to resubmit any of the declined items, open an issue first describing the problem and the evidence, and we'll take it from there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens RigLogic runtime stability across hypervisors, malformed DNA streams, Python SWIG bindings, and vectorized solvers, and introduces missing inspection tools.
Linked issue
Fixes multiple stability edge cases and crashes reported on hypervisors, SWIG string passing, and DNA binary stream validation.
What changed and why
emoveByIndex, and RawVertexSkinWeights against corrupted or truncated DNA files.
ewOutputIndices on each column iteration.
Test plan
iglogic-tests, rimd-tests, pydna-tests).
Checklist