Skip to content

Bugfix: Undefined variable in POIExt#11

Merged
JulStraus merged 5 commits into
mainfrom
fix/POIExt
Jun 24, 2026
Merged

Bugfix: Undefined variable in POIExt#11
JulStraus merged 5 commits into
mainfrom
fix/POIExt

Conversation

@danareu

@danareu danareu commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

This PR fixes two bugs in POIExt that occured during the previous PR:

  • Fix undefined variable 𝒽 and use 𝒽₀ instead
  • Define op_per_strat variable as previously undefined

@danareu danareu requested a review from JulStraus June 24, 2026 08:41

@JulStraus JulStraus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bugfix is related to #9 and will close #10. There is one thing you must fix before we can merge it: Update the version number in the Project.toml file as well.

@danareu

danareu commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator Author

@JulStraus Update the version number in Project.toml

@JulStraus JulStraus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will merge once the CI ran through

@JulStraus JulStraus changed the title Fix/poi ext Bugfix: Undefined variable in POIExt Jun 24, 2026
@JulStraus JulStraus merged commit bf36eab into main Jun 24, 2026
5 checks passed
@JulStraus JulStraus deleted the fix/POIExt branch June 24, 2026 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants