fix: stamp CFBundleVersion into app bundle and repo during build & release#13
Open
Copilot wants to merge 1 commit into
Open
fix: stamp CFBundleVersion into app bundle and repo during build & release#13Copilot wants to merge 1 commit into
Copilot wants to merge 1 commit into
Conversation
… during build & release
Copilot created this pull request from a session on behalf of
Eliezergh
June 7, 2026 18:01
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setup/setup.pyhad hardcodedCFBundleVersion/CFBundleShortVersionString('1.0.0') that were never touched by the workflow, so every built.appreported the wrong version to macOS (Finder "Get Info", Spotlight, system dialogs). The in-app About dialog was fine since it readsAPP_VERSIONfromcore.py, which was already stamped.Changes
Build job — "Stamp version into source": extends the Python stamping step to also patch
CFBundleVersionandCFBundleShortVersionStringinsetup/setup.pybeforepy2appruns, so the distributed.appbundle carries correct macOS metadata:Release job — "Finalize version bump and tag": adds
sedcommands forsetup/setup.pyand includes it in the version-bump commit pushed tomain.Cleanup: removed the redundant
src/syndi.pystamping — that file only importsAPP_VERSION, never defines it, so those substitutions were no-ops.