Repository navigation
Conversation
Andezion
force-pushed
the
fix/elements-block-header-overread
branch
from
October 1, 2026 15:12
8d09ab2 to
b3cc1d1
Compare
Andezion
force-pushed
the
fix/elements-block-header-overread
branch
from
October 26, 2026 12:58
b3cc1d1 to
6019190
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #9485, which fixed truncated Bitcoin blocks. The same kind of bad block still crashed the Elements/Liquid header parser:
pull()checked the length. A truncated header caused a heap over-read, then a NULL dereference (sha256_update(shactx, NULL, 4))pull()after an earlier failure hitassert(p)Separately, for all chains, a huge tx count made
tal_arr()overflow and abortAs in #9485, this needs the chain backend to serve a bad block. A peer cannot trigger it
Fix
pull_and_hash(), which hashes only the bytes thatpull()returns, and use it for all hashed header fieldspull()fail cleanly when the cursor is already NULLTesting
run-bitcoin_block_from_hexnow builds smallliquid-regtestblocks (with and without dynafed) and checks that each one parses and that every truncation of it is rejected. It also checks huge extension space, signblock-witness and tx counts. Disabling any single part of the fix makes the test abort, segfault or hangImportant
26.09 FREEZE August 5th: Non-bugfix PRs not ready by this date will wait for 26.12.
RC1 is scheduled on August 17th
The final release is scheduled for September 7th.
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:
tools/lightning-downgrade