Remove SwiftyBeaver and rebuild logging on OSLog#454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the SwiftyBeaver dependency entirely and rebuilds the app's logging stack on Apple's unified logging (
OSLog/Logger). Replaces the old file-based log viewer with a live in-app App Activity Logs feature backed by a newLogsClientmodule, and resyncs all localizations.What changed
Logging backend
OSLog:AppFeature,AppTools,AppModels,DownloadClient,DatabaseClient,NetworkingFeature,ParserFeature,ReadingFeature,BackgroundProcessingClient,SettingFeature(WebView +LoginReducer).SwiftyBeaverExtmodule withOSLogExt(shared app identifier), and renameLoggerClient→LogsClient.private let loggerin each file that logs; drop noisy UI-layer log calls.App Activity Logs feature
AppActivityLogmodel andRunLogFile(identified by file URL) for per-run log files; app activity events logged atnoticelevel.LogsClientmodule and a rebuilt log viewer with a live pump plus a Run picker (Current section + sheet, run time shown as HHmm, capped at 5 runs including current) and an "Open in Files" button.LogsReducer/LogsViewand the dead file-based log APIs inFileClient,LibraryClient, andApplicationClient.Localizations
enand add the new logs keys.Localizable.stringsfile headers and the "Copied from" attribution comments.Housekeeping
AppToolshelpers under anExtensions/folder.