fix(audio): increase VS1053b init timing margins for early-batch chips#7239
Open
raphaelcoeffic wants to merge 1 commit intomainfrom
Open
fix(audio): increase VS1053b init timing margins for early-batch chips#7239raphaelcoeffic wants to merge 1 commit intomainfrom
raphaelcoeffic wants to merge 1 commit intomainfrom
Conversation
Some X12S radios with early-batch VS1053b chips fail to initialize audio after the streamlined init in 12febed. Increase timing margins: - Wait for DREQ before each SPI command (not just after) - Increase hard reset DREQ timeout from 3ms to 5ms and add 20ms settle - Increase post-CLOCKF DREQ timeout from 1ms to 5ms for PLL relock
raphaelcoeffic
added
hardware support
bug/regression ↩️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some X12S radios with early-batch VS1053b chips fail to initialize audio after the streamlined init in 12febed. Increase timing margins:
Fixes #6412