feat(radio): allow user to choose only one log file per day

[3djc]

This fixes an issue introduced by an old change (#550) that introduced time based logs instead of one per day. This unfortunately ignored the fact that FAT32 doesn't like at all directories with large number of files, and also that some user simply prefer less log files

This allows users to opt in for one log file per day. I personally think that should be the default behavior for the FAT32 reason above, but I did not go that far to not contradict early ETX decisions

This fixes #6965

@elecpower , could you take care of companion part ?

[elecpower]

@elecpower , could you take care of companion part ?

Yes

[Johanl1964]

Will this be optional? I fly RC gliders myself with both long and many flights during a day! Uses ELRS, GPS, Vario etc, logs with 0.3 sec. So each minute of flight gives about 72 kb, so for example a common 90 minute flight gives about 6.5MB, and it is not uncommon that there can be a total of 6 hours of flight during a day, so if this were to be collected in the same file it would be about 26MB which would probably create problems because it is already tough to handle files over 5MB

[Johanl1964]

Will this be optional? I fly RC gliders myself with both long and many flights during a day! Uses ELRS, GPS, Vario etc, logs with 0.3 sec. So each minute of flight gives about 72 kb, so for example a common 90 minute flight gives about 6.5MB, and it is not uncommon that there can be a total of 6 hours of flight during a day, so if this were to be collected in the same file it would be about 26MB which would probably create problems because it is already tough to handle files over 5MB

Tested now, and saw you can choose, so there was no danger of too large log files that could break the transmitter/Companion

[3djc]

Not should there be any. It should handle large files without specific issues, much better than large directories anyway

[Johanl1964]

Not should there be any. It should handle large files without specific issues, much better than large directories anyway

I usually download the log files to the computer (Linux). But those over 5mb become/are very sluggish in Companion, and files over 8mb can cause Companion to hang, and this applies to several of my Linux computers!

[pfeerick]

I.e. you're experiencing #7159 also

[pfeerick]

This is something I think we (by we I probably mean me 🤪) should include in 2.12 (i.e. 2.12.1) and also backport to 2.11.

[3djc]

This is something I think we (by we I probably mean me 🤪) should include in 2.12 (i.e. 2.12.1) and also backport to 2.11.

i won't disagree ! Shoot if you want me to work on something

[Johanl1964]

I.e. you're experiencing #7159 also

That's right, I've been using the latest V3 Companion for a long time, but the versions in recent months have been slightly faster, but the problem remains...

[Johanl1964]

Today I tested "on log per day" in practice (in the air). Works fine except that Companion (Linux) handles large CSV files extremely sluggishly and slowly.... Today's file was "only" about 23mb, it can actually be double that during a whole day of flights, and then there will probably be problems!?

[pfeerick]

Today I tested "on log per day" in practice (in the air). Works fine except that Companion (Linux) handles large CSV files extremely sluggishly and slowly.... Today's file was "only" about 23mb, it can actually be double that during a whole day of flights, and then there will probably be problems!?

See #7159.

[elecpower]

PR #7205 should improve performance

[Johanl1964]

PR #7205 should improve performance

PR #7205 should improve performance

Have now tested the companion (Linux), now works really fast with large files, nice work!