fix: Bootstrap 5 で廃止されたクラスを置き換える - #101
Open
dotani1111 wants to merge 1 commit into
Open
Conversation
- form-group → mb-3 / text-right → text-end / text-left → text-start / mr-* → me-* / ml-* → ms-* - 置き換え先は本体 4.4 の管理画面テンプレート (admin/Product/index.twig) の 記法に合わせる Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
#95 のレビューでご指摘いただいた、Bootstrap 5 で廃止されたクラスの残存を置き換えます。
ご指摘の
form-group/text-rightに加え、同種の廃止クラスを管理画面テンプレート全体で洗い出して置き換えています。方針(Policy)
admin/Product/index.twig等)の記法に合わせるdata-toggle等のdata-bs-*化は移行済みでした実装に関する補足(Appendix)
置き換え内容は次のとおりです。
form-groupmb-3text-righttext-endtext-lefttext-startmr-1/mr-2/mr-3me-1/me-2/me-3ml-2ms-2index.twigの検索フォームにあるrangeクラスは Bootstrap のクラスではない(本体にも定義なし)ため、そのまま残しています。テスト(Test)
マイナーバージョン互換性保持のための制限事項チェックリスト
※ 変更は twig の class 属性のみで、PHP の変更はありません。
レビュワー確認項目
🤖 Generated with Claude Code