shells/bash: fix build failure on DragonFly#1562
Closed
dragonflybot wants to merge 1 commit into
Closed
Conversation
> Generated by the DragonFly agentic build-fix loop and verified in a clean dev-env. Reviewed and accepted by operator `operator` before submission. ## Problem The build failed on `@2026Q2` — classified `patch-error`, confidence `high`. The static DragonFly-specific patch `dragonfly/patch-lib_readline_terminal.c` fails to apply against bash‑5.3.9 because the targeted source file `lib/readline/terminal.c` has changed upstream, shifting the hunk context. A prior triage converted this to a `dops` `REINPLACE_CMD` operation, but the static patch file either still exists in the materialized `dragonfly` directory or the conversion was not picked up by this build run. **Evidence:** - `1 out of 1 hunks failed--saving rejects to lib/readline/terminal.c.rej` - `===> FAILED Applying dragonfly patch-lib_readline_terminal.c` - `===> FAILED to apply cleanly dragonfly patch(es) patch-lib_readline_terminal.c` ## Fix Automated fix for the build failure in `shells/bash`. ## What changed 2 files changed, +5/-16 - `ports/shells/bash/dragonfly/patch-lib_readline_terminal.c` - `ports/shells/bash/overlay.dops` ## Verification Built successfully in a DragonFly dev-env (dsynth) for target `@2026Q2`. Verified 2026-06-16T23:32:37.891313+00:00. ## Provenance - Operator: operator - Agent: model=deepseek/deepseek-v4-pro attempts=1 tokens=350011 Signed-off-by: Fred [bot] <github@dragonflybsd.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The build failed on
@2026Q2— classifiedpatch-error, confidencehigh.The static DragonFly-specific patch
dragonfly/patch-lib_readline_terminal.cfails to apply against bash‑5.3.9 because the targeted source filelib/readline/terminal.chas changed upstream, shifting the hunk context. A prior triage converted this to adopsREINPLACE_CMDoperation, but the static patch file either still exists in the materializeddragonflydirectory or the conversion was not picked up by this build run.Evidence:
1 out of 1 hunks failed--saving rejects to lib/readline/terminal.c.rej===> FAILED Applying dragonfly patch-lib_readline_terminal.c===> FAILED to apply cleanly dragonfly patch(es) patch-lib_readline_terminal.cFix
Automated fix for the build failure in
shells/bash.What changed
2 files changed, +5/-16
ports/shells/bash/dragonfly/patch-lib_readline_terminal.cports/shells/bash/overlay.dopsVerification
Built successfully in a DragonFly dev-env (dsynth) for target
@2026Q2.Verified 2026-06-16T23:32:37.891313+00:00.
Provenance