graphics/ttyplot: fix build failure on DragonFly#1553
Merged
Conversation
> Generated by the DragonFly agentic build-fix loop and verified in a clean dev-env. Reviewed and accepted by operator `operator` before submission. ## Problem The build failed on `@2026Q2` — classified `compile-error`, confidence `high`. The port's existing patch only defines `_XOPEN_SOURCE_EXTENDED` for `__APPLE__` and `__FreeBSD__`, but not for `__DragonFly__`. On DragonFly, this causes several POSIX/BSD symbols (`isfinite`, `NAN`, `optreset`, `SIGWINCH`) to remain undeclared because the feature-test macros aren't activated. **Evidence:** - `ttyplot.c:433:15: warning: implicit declaration of function 'isfinite'` - `ttyplot.c:581:22: error: 'NAN' undeclared` - `ttyplot.c:636:5: error: 'optreset' undeclared` - `ttyplot.c:727:12: error: 'SIGWINCH' undeclared` - Existing overlay patch `patch-ttyplot.c` adds `|| defined (__FreeBSD__)` but does not mention `__DragonFly__`. ## Fix Automated fix for the build failure in `graphics/ttyplot`. ## What changed 3 files changed, +11/-7 - `ports/graphics/ttyplot/Makefile.DragonFly` - `ports/graphics/ttyplot/STATUS` - `ports/graphics/ttyplot/overlay.dops` ## Verification Built successfully in a DragonFly dev-env (dsynth) for target `@2026Q2`. Verified 2026-06-07T09:29:16.788680+00:00. ## Provenance - Operator: operator - Agent: model=deepseek/deepseek-v4-pro attempts=1 tokens=372453 Signed-off-by: Fred [bot] <github@dragonflybsd.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The build failed on
@2026Q2— classifiedcompile-error, confidencehigh.The port's existing patch only defines
_XOPEN_SOURCE_EXTENDEDfor__APPLE__and__FreeBSD__, but not for__DragonFly__. On DragonFly, this causes several POSIX/BSD symbols (isfinite,NAN,optreset,SIGWINCH) to remain undeclared because the feature-test macros aren't activated.Evidence:
ttyplot.c:433:15: warning: implicit declaration of function 'isfinite'ttyplot.c:581:22: error: 'NAN' undeclaredttyplot.c:636:5: error: 'optreset' undeclaredttyplot.c:727:12: error: 'SIGWINCH' undeclaredpatch-ttyplot.cadds|| defined (__FreeBSD__)but does not mention__DragonFly__.Fix
Automated fix for the build failure in
graphics/ttyplot.What changed
3 files changed, +11/-7
ports/graphics/ttyplot/Makefile.DragonFlyports/graphics/ttyplot/STATUSports/graphics/ttyplot/overlay.dopsVerification
Built successfully in a DragonFly dev-env (dsynth) for target
@2026Q2.Verified 2026-06-07T09:29:16.788680+00:00.
Provenance