devel/readline: fix build failure on DragonFly#1545
Merged
Conversation
> Generated by the DragonFly agentic build-fix loop and verified in a clean dev-env. Reviewed and accepted by operator `operator` before submission.
## Problem
The build failed on `@2026Q2` — classified `compile-error`, confidence `high`.
The DeltaPorts overlay patch `dragonfly/patch-terminal.c` is malformed: the line adding support for the `cons25` terminal type has a double `+` (`++ dumbterm = ...`), causing the first `+` to leak from the unified-diff format into the source code as a literal unary-plus operator. The compiler then rejects `+ dumbterm = ...` as a non‑lvalue assignment.
**Evidence:**
- Compile error from `terminal.c`:
```
./terminal.c: In function '_rl_init_terminal_io':
./terminal.c:583:13: error: lvalue required as left operand of assignment
+ dumbterm = STREQ (term, "dumb") || STREQ (term, "vt52") || STREQ (term, "adm3a") || STREQ (term, "cons25");
^
```
The leading `+` before “dumbterm” is a stray diff‑addition marker, not part of the intended code.
## Fix
Automated fix for the build failure in `devel/readline`.
## What changed
1 file changed, +1/-2
- `ports/devel/readline/dragonfly/patch-terminal.c`
## Verification
Built successfully in a DragonFly dev-env (dsynth) for target `@2026Q2`.
Verified 2026-05-30T22:47:24.849883+00:00.
## Provenance
- Operator: operator
- Agent: model=deepseek/deepseek-v4-pro attempts=1 tokens=457701
Signed-off-by: Fred [bot] <github@dragonflybsd.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The build failed on
@2026Q2— classifiedcompile-error, confidencehigh.The DeltaPorts overlay patch
dragonfly/patch-terminal.cis malformed: the line adding support for thecons25terminal type has a double+(++ dumbterm = ...), causing the first+to leak from the unified-diff format into the source code as a literal unary-plus operator. The compiler then rejects+ dumbterm = ...as a non‑lvalue assignment.Evidence:
terminal.c:+before “dumbterm” is a stray diff‑addition marker, not part of the intended code.Fix
Automated fix for the build failure in
devel/readline.What changed
1 file changed, +1/-2
ports/devel/readline/dragonfly/patch-terminal.cVerification
Built successfully in a DragonFly dev-env (dsynth) for target
@2026Q2.Verified 2026-05-30T22:47:24.849883+00:00.
Provenance