devel/readline: fix build failure on DragonFly#1544
Closed
dragonflybot wants to merge 1 commit into
Closed
Conversation
> Generated by the DragonFly agentic build-fix loop and verified in a clean dev-env. Reviewed and accepted by operator `operator` before submission.
## Problem
The build failed on `@2026Q2` — classified `compile-error`, confidence `medium`.
The FreeBSD base port applies a patch to `terminal.c` that adds the `cons25` termtype to the `dumbterm` assignment. During materialisation into DeltaPorts the patch was not applied correctly – the leading `+` from the patch’s unified-diff context ended up as a literal character in the source line. This turns the expression into `+ dumbterm`, a unary-plus that is not an lvalue, and the compiler rejects it.
**Evidence:**
- Compile error and the offending line (with a literal leading `+`):
```
./terminal.c: In function '_rl_init_terminal_io':
./terminal.c:583:13: error: lvalue required as left operand of assignment
+ dumbterm = STREQ (term, "dumb") || STREQ (term, "vt52") || STREQ (term, "adm3a") || STREQ (term, "cons25");
^
```
- `cons25` is a FreeBSD-specific console terminal type; it does not exist in upstream GNU readline source. This confirms that a FreeBSD-originated patch modified `terminal.c`, and that the patch was mangled when applied.
## Fix
Automated fix for the build failure in `devel/readline`.
## What changed
1 file changed, +1/-0
- `ports/devel/readline/overlay.dops`
## Verification
Built successfully in a DragonFly dev-env (dsynth) for target `@2026Q2`.
Verified 2026-05-28T22:56:55.782297+00:00.
## Provenance
- Operator: operator
- Agent: model=deepseek/deepseek-v4-pro attempts=1 tokens=147077
Signed-off-by: Fred [bot] <github@dragonflybsd.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The build failed on
@2026Q2— classifiedcompile-error, confidencemedium.The FreeBSD base port applies a patch to
terminal.cthat adds thecons25termtype to thedumbtermassignment. During materialisation into DeltaPorts the patch was not applied correctly – the leading+from the patch’s unified-diff context ended up as a literal character in the source line. This turns the expression into+ dumbterm, a unary-plus that is not an lvalue, and the compiler rejects it.Evidence:
+):cons25is a FreeBSD-specific console terminal type; it does not exist in upstream GNU readline source. This confirms that a FreeBSD-originated patch modifiedterminal.c, and that the patch was mangled when applied.Fix
Automated fix for the build failure in
devel/readline.What changed
1 file changed, +1/-0
ports/devel/readline/overlay.dopsVerification
Built successfully in a DragonFly dev-env (dsynth) for target
@2026Q2.Verified 2026-05-28T22:56:55.782297+00:00.
Provenance