CSparse: Adjust letter-case of CMake target to other libraries.#1042
Open
mmuetzel wants to merge 7 commits into
Open
CSparse: Adjust letter-case of CMake target to other libraries.#1042mmuetzel wants to merge 7 commits into
mmuetzel wants to merge 7 commits into
Conversation
The letter-case of the targets as they are used in the top-level CMakeLists.txt file didn't match the letter case in the CMakeLists.txt file for the CSparse library. Use the letter-case of the targets in the top-level CMakeLists.txt file because it is more consistent with the letter-case of most other library targets (most importantly CXSparse). Fixes DrTimothyAldenDavis#1041.
Rename demo executables and targets so their names are different from the ones of the CXSparse library.
Add flags `--config Release` to `cmake` command in "install" step.
mmuetzel
changed the title
GitHub recently updated to Visual Studio 2026 on their `windows-latest` image. See: actions/runner-images#14017 CUDA 12.5 (as installed by Jimver/cuda-toolkit) does not support Visual Studio 2026. Update the installed CUDA version to 13.2.0.
Support for the architectures 52 (Maxwell) and 60 (Pascal) have been removed in CUDA 13.2.0. Build for newer architectures instead. According to Google AI these are: 75: Turing (e.g., RTX 20-series, GTX 16-series, T4) 80: Ampere Datacenter (e.g., A100) 86: Ampere Consumer (e.g., RTX 30-series) 89: Ada Lovelace (e.g., RTX 40-series)
Contributor
Author
|
This needed a couple of follow-up changes to get the CI configurations to build again. |
Some tests seem to be hanging (indefinitely?). Reduce the timeout to 5 minutes (from the default 25 minutes) per test to unblock the CI runners a bit faster.
Contributor
Author
|
It looks like some tests are failing on the MSVC runners with CUDA: Even more tests (maybe all tests for CHOLMOD?) are timing out with shared libraries. The entire CI run seems to have failed for a different(?) reason. (It's still showing as incomplete.) Maybe an incompatibility with newer CUDA versions? That would be out of my expertise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The letter-case of the targets as they are used in the top-level CMakeLists.txt file didn't match the letter case in the CMakeLists.txt file for the CSparse library.
Use the letter-case of the targets in the top-level CMakeLists.txt file because it is more consistent with the letter-case of most other library targets (most importantly CXSparse).
Additionally, build the CSparse library as part of the CI using the root CMakeLists.txt file on Ubuntu.
Fixes #1041.