Skip to content

add translations for 3 manybrains tasks, setup instrument guidelines - #30

Merged
joshunrau merged 8 commits into
mainfrom
maxime-clean
Jun 4, 2026
Merged

add translations for 3 manybrains tasks, setup instrument guidelines#30
joshunrau merged 8 commits into
mainfrom
maxime-clean

Conversation

@joshunrau

@joshunrau joshunrau commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • New Features

    • Added bilingual (English/French) localization support to interactive instruments, including translated UI text, instructions, and language selection options.
  • Documentation

    • Updated README with installation setup instructions.
  • Chores

    • Updated configuration files and dependencies.

@joshunrau
joshunrau merged commit 8bebd66 into main Jun 4, 2026
1 check was pending
@coderabbitai

coderabbitai Bot commented Jun 4, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 92276650-3a35-4b84-a43b-58a4dcee25a7

📥 Commits

Reviewing files that changed from the base of the PR and between b74a6fc and aa61cac.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (21)
  • .gitignore
  • .nvmrc
  • AGENTS.md
  • CLAUDE.md
  • README.md
  • lib/interactive/TMB_DIGIT_SYMBOL_MATCHING/index.ts
  • lib/interactive/TMB_DIGIT_SYMBOL_MATCHING/render.js
  • lib/interactive/TMB_DIGIT_SYMBOL_MATCHING/translator.ts
  • lib/interactive/TMB_SIMPLE_RT/_SimpleRT.webp
  • lib/interactive/TMB_SIMPLE_RT/_SimpleRT_EN.webp
  • lib/interactive/TMB_SIMPLE_RT/_SimpleRT_FR.webp
  • lib/interactive/TMB_SIMPLE_RT/index.ts
  • lib/interactive/TMB_SIMPLE_RT/render.js
  • lib/interactive/TMB_SIMPLE_RT/translator.ts
  • lib/interactive/TMB_VISUAL_PA_STUDY/index.ts
  • lib/interactive/TMB_VISUAL_PA_STUDY/render.js
  • lib/interactive/TMB_VISUAL_PA_STUDY/translator.ts
  • lib/interactive/TMB_VISUAL_PA_TEST/index.ts
  • lib/interactive/TMB_VISUAL_PA_TEST/render.js
  • lib/interactive/TMB_VISUAL_PA_TEST/translator.ts
  • package.json

Walkthrough

Four interactive test instruments are updated to support English and French bilingual rendering. Configuration schemas now declare language arrays, language-keyed metadata, and localized user-facing text. Render functions initialize translator instances and replace all hardcoded English strings with localized lookups. Repository configuration is updated with Node.js pinning and tooling dependencies.

Changes

Bilingual Instrumentation Localization

Layer / File(s) Summary
Repository setup and tooling
.gitignore, .nvmrc, package.json, README.md
Node.js version pinned to LTS/krypton, instrument-guidelines added to devDependencies, gitignore entries updated to exclude generated and local config files, and README documents agent-guidelines setup.
TMB Digit Symbol Matching bilingual support
lib/interactive/TMB_DIGIT_SYMBOL_MATCHING/index.ts, lib/interactive/TMB_DIGIT_SYMBOL_MATCHING/translator.ts, lib/interactive/TMB_DIGIT_SYMBOL_MATCHING/render.js
Instrument configuration declares ['en','fr'] language array, language-keyed tags, and version 2. Configuration includes localized instructions, descriptions, and titles. New translator.ts exports English/French translation dictionary. Render function initializes translator and replaces all UI text with localized lookups.
TMB Simple RT bilingual support
lib/interactive/TMB_SIMPLE_RT/index.ts, lib/interactive/TMB_SIMPLE_RT/translator.ts, lib/interactive/TMB_SIMPLE_RT/render.js
Instrument configuration declares bilingual languages, language-keyed tags and measure labels, and version 2. Language-specific static assets (SimpleRT_EN.gif and SimpleRT_FR.gif) replace single asset. New translator.ts exports English/French strings. Render function initializes translator, selects language-specific title image, and replaces stimulus labels, button text, and frame HTML with localized lookups.
TMB Visual PA Study bilingual support
lib/interactive/TMB_VISUAL_PA_STUDY/index.ts, lib/interactive/TMB_VISUAL_PA_STUDY/translator.ts, lib/interactive/TMB_VISUAL_PA_STUDY/render.js
Instrument configuration declares bilingual languages, language-keyed tags, version 2, and enables language selection. Localized instructions, descriptions, and titles are configured. New translator.ts exports button labels, counter text, and study flow translations. Render function initializes translator and replaces button labels, counter display, and frame messages with localized lookups.
TMB Visual PA Test bilingual support
lib/interactive/TMB_VISUAL_PA_TEST/index.ts, lib/interactive/TMB_VISUAL_PA_TEST/translator.ts, lib/interactive/TMB_VISUAL_PA_TEST/render.js
Instrument configuration declares bilingual languages, language-keyed tags, version 2, and enables language selection. Localized instructions, descriptions, and titles configured. New translator.ts exports button labels, counter text, test headings, and feedback message translations. Render function initializes translator and replaces all UI text (alerts, button labels, feedback, counter, frame sequences) with localized lookups.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

  • DouglasNeuroInformatics/ODC_Instruments#1: Both PRs update .gitignore, with the main PR and retrieved PR both adding/adjusting an ignore entry for settings.local.json.
  • DouglasNeuroInformatics/ODC_Instruments#28: The main PR's bilingual i18n changes (using interactive content knobs like language: ['en','fr'], enableLanguageSelect/enableLanguageLock, and translator-driven UI text) align with the runtime-v1/AGENTS.md schema updates described in the retrieved PR, even though AGENTS.md itself was removed in the main PR.

Poem

🌍 Four instruments now speak in tongues twain,
English and French through translator's domain,
Static assets bloom in linguistic dress,
Labels and buttons in bilingual finesse,
The TestMyBrain suite goes worldwide, we confess! 🧠✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch maxime-clean

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@joshunrau
joshunrau deleted the maxime-clean branch June 4, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant