Primitive types#52
Open
DomCR wants to merge 2 commits into
Open
Conversation
Updated `Camera` with `FarPlane` and `OrthographicZoom` properties. Refactored `Light` to include an empty body. Improved `Box` class with better `ToMesh` logic. Enhanced `Primitive` with a summary, reordered properties, and added a protected constructor. Introduced `Plane` class with `ToMesh` implementation and properties for planar geometry. Added `Sphere` class with `Center` and `Radius` properties and a placeholder `ToMesh` method. Improved maintainability and extended geometric capabilities.
Added constructors for the `Sphere` class, including a parameterless constructor and one accepting a `name`. Implemented the `ToMesh` method to generate vertices, normals, UVs, and polygons for a sphere mesh, handling top and bottom poles. Removed the `NotImplementedException` from the `ToMesh` method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Short description about this PR
Tasks done in this PR
Related Issues / Pull Requests
Notes for reviewer