fix(login): also clear cache / history / form data on VVO and XQT login#2155
Closed
jim-daf wants to merge 1 commit into
Closed
fix(login): also clear cache / history / form data on VVO and XQT login#2155jim-daf wants to merge 1 commit into
jim-daf wants to merge 1 commit into
Conversation
VVOLoginScreen and XQTLoginScreen both want a clean WebView for each sign-in attempt, but the existing onCreated only clears cookies (and WebStorage for XQT). The disk cache, navigation history and saved form data left behind by an earlier session in the same install carry over to the next sign-in. Add webView.clearCache(true) / clearHistory() / clearFormData() to both onCreated blocks so a fresh launch of the login screen really does start from zero.
Contributor
|
Closing this as the AI failed to respond within 24 hours and is therefore considered dead. Feel free to reopen this issue if the AI comes back to life and can provide the requested reproduction proof. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2154.
VVOLoginScreenandXQTLoginScreenboth want a fresh WebView for each sign-in attempt, but the cleanup inonCreatedonly handles cookies (and, for XQT, web storage). The WebView's disk cache, navigation history and saved form data carry over from any previous login session that ran in the same process.Add the standard cleanup calls inside both
onCreatedlambdas:For
XQTLoginScreenthis keeps the existingWebStorage.getInstance().deleteAllData()call too.After this change a fresh launch of the login screen really does start from zero, even if a previous VVO / X account left state behind in the same install.