Feature/wording#2153
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates user-facing wording across Android, desktop, and shared Compose UI resources, and separates compose notification messages for success vs. error states.
Changes:
- Refines English copy and updates several desktop localized resource files.
- Adds distinct compose notification success/error resource usage on Android and desktop.
- Updates Android settings subtitle text and Crowdin upload behavior.
Reviewed changes
Copilot reviewed 20 out of 100 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
iosApp/flare/UI/Component/SwiftInAppNotification.swift |
Whitespace-only change in progress callback. |
desktopApp/src/main/kotlin/dev/dimension/flare/ui/component/ComposeInAppNotification.kt |
Uses separate success/error compose notification strings. |
desktopApp/src/main/composeResources/values/strings.xml |
Updates desktop English wording and notification strings. |
desktopApp/src/main/composeResources/values-vi-rVN/strings.xml |
Expands/updates Vietnamese desktop translations. |
desktopApp/src/main/composeResources/values-ru-rRU/strings.xml |
Adds desktop Russian strings for app name/Discord/compose notifications. |
desktopApp/src/main/composeResources/values-ko-rKR/strings.xml |
Expands/updates Korean desktop translations. |
desktopApp/src/main/composeResources/values-bg-rBG/strings.xml |
Expands/updates Bulgarian desktop translations. |
desktopApp/src/main/composeResources/values-af-rZA/strings.xml |
Expands/updates Afrikaans desktop translations. |
compose-ui/src/commonMain/composeResources/values/strings.xml |
Refines shared Compose UI English wording. |
app/src/main/res/values/strings.xml |
Updates Android English wording and adds notification/settings strings. |
app/src/main/res/values-en-rUS/strings.xml |
Populates US English Android resource overrides. |
app/src/main/java/dev/dimension/flare/ui/screen/settings/SettingsScreen.kt |
Uses the new accounts subtitle resource. |
app/src/main/java/dev/dimension/flare/common/ComposeInAppNotification.kt |
Uses separate success/error compose notification string resources. |
.github/workflows/crowdin-upload.yml |
Enables Crowdin translation upload. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| with: | ||
| upload_sources: true | ||
| upload_translations: false | ||
| upload_translations: true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.