Skip to content

Make it compatible with Laravel 8 #30

Description

@didix16

Hi.

I'm trying to make it work with my Laravel 8 installation but it seems this package is outdated with new Laravel version.

I'm having problems with runCommand method from all of your commands.

// This is the expected method interface

protected function runCommand($command, $path, OutputInterface $output)

// this is the current interface

protected function runCommand($command, $path)

// These are the errors that i get from:

 ErrorException 

  Declaration of devmtm\NovaCustomViews\ViewsCommand::runCommand($command, $path) should be compatible with Illuminate\Console\Command::runCommand($command, array $arguments, Symfony\Component\Console\Output\OutputInterface $output)

  at vendor/digitalcloud/nova-custom-views/src/commands/ViewsCommand.php:212
 ErrorException 

  Declaration of devmtm\NovaCustomViews\DashboardViewCommand::runCommand($command, $path) should be compatible with Illuminate\Console\Command::runCommand($command, array $arguments, Symfony\Component\Console\Output\OutputInterface $output)

  at vendor/digitalcloud/nova-custom-views/src/commands/DashboardViewCommand.php:163

Etc...

Edit

BTW: Process class interface should be updated.

Its constructor expects an array and now a string is given

Argument 1 passed to Symfony\Component\Process\Process::__construct() must be of the type array, string given,

End edit

Could you make it compatible with Laravel 8?

Thank you so much

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions