Conversation
added 7 commits
March 27, 2019 10:32
…field itseld and counts on the latitude, longitude and name fields instead
|
Hello @sash According to your commit, I make a quick revision by the code. I have some unclear points regarding them. Therefore, can you please at first update the Read Me file, so that me and others can understand what are the new added features is, and how we can use it. Then we can discuss other points. Regards |
…dd-time-zone-option-in add: timezone autoselect functionality using google timezone api [sc-…
…dinates instead of google timezone api [sc-49574]
Feature/sc 57782 google address picker
…ravel Nova styles update
…mplete [sc-147738]
…nting-and-prevent-multiple-pins Display pin on mounting and prevent multiple pins on selecting address from autocomplete
# Conflicts: # main/app/Http/Controllers/App/Bootstrap/OperatorSettingsController.php # main/app/Http/DataTransferObjects/App/OperatorSettingsApiData.php # main/tests/Feature/App/Settings/OperatorSettingsApiTest.php
…roperty can be reactive
Make the AddressField support dependent Nova fields + the countries property can be reactive
Resolved dist/js/field.js with the nova5 build (matches what the backend runs). FormField.vue auto-merged, so master's state/city fix is in source but NOT yet compiled into dist — rebuild dist against the Nova 5 toolchain as a follow-up to ship it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018hP4VdTDdpTnzZ9KDcpvwR
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018hP4VdTDdpTnzZ9KDcpvwR
… [sc-1152788] The picker emitted an unscoped `state-value` for countries with predefined states, and emitted only `-value` (never `-change`) for the other derived fields. Nova subscribes form fields to `<formUniqueId>-<attribute>-value` and resolves `dependsOn` exclusively off `<formUniqueId>-<attribute>-change`, so neither reached its target: - the consuming app's state Select was never shown or populated, because its `dependsOn(['country'])` never fired, and - the value carried Google's long administrative-area name rather than the short code that state validation expects. Emit `<formUniqueId>-<region>_state-value` / `-change` with the short code for region-state countries, keep the scoped `<region>` events for the rest, and add the matching `-change` emits for countryCode, country, locality, address, street address and postal code. This restores behaviour that had been carried as a downstream composer patch in the consuming application. The patch was dropped on the assumption it was already compiled into the v2.0 dist; it was not, which broke location creation for countries with predefined states. dist/js/field.js is edited in place rather than regenerated: `yarn production` currently fails in this repo because package.json lacks the `uid` and `vuex` deps that Nova 5's mixins require. Rebuilding the bundle needs that fixed first and is deliberately kept out of this fix. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DnAqcq511BKjBg3BHmMAsP
…-emit fix: emit form-scoped state and change events from the address picker…
…er one key [sc-1172155] Autocomplete mapped administrative_area_level_1 to the city for countries without a predefined state list and wrote the street to a misspelled streetAaddress key that the translated street address branch never read. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012tencr2W3w3G294YEND9ym
…ty-and-street-address fix: derive city from locality components and emit street address under one key [sc-1172155]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.