Adds a new page for Jungfrau rotations #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
olliesilvester
approved these changes
Jan 23, 2026
Contributor
olliesilvester
left a comment
olliesilvester
left a comment
There was a problem hiding this comment.
I don't know enough to comment too much on the code quality but it works and matches the parameters needed on the bluesky side
| | "ForceSwitchG2" | ||
| | "FixG1" | ||
| | "FixG2" | ||
| | "FixG0"; |
Contributor
There was a problem hiding this comment.
In the ophyd-async Enum I put a comment before the FIX_G0: # Use with caution - this may damage the detector. (I got this from an operations guide for the Jungfrau which is now deprecated).
Could put a similar message on the screen around this option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #59
Needs mx-bluesky#1565