Repository navigation
Remove explicitly setting frames per chunk to 1 - #661
Merged
Merged
Conversation
yousefmoazzam
force-pushed
the
simplify-frames-per-chunk-mutation
branch
from
December 9, 2025 10:59
e6f5f77 to
3c51d04
Compare
The frames per chunk need not be set to 1 unless the minimum block length is 1. So, the `if` statement that remains, which sets the frames per chunk to be the same as the minimum block length under the appropriate condition, is sufficient to ensure a frames per chunk value that will work across all blocks within a section.
yousefmoazzam
force-pushed
the
simplify-frames-per-chunk-mutation
branch
from
December 9, 2025 14:14
3c51d04 to
871f40b
Compare
Collaborator
Author
|
It was discussed in sprint planning that this was good to go. The IRIS CI is currently failing due to a lack of a release of httomolib that contains the new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #659
Fixes IMGDA-674
Checklist