Repository navigation
Iterative search method for memory estimator - #652
Merged
Merged
Conversation
mfep
force-pushed
the
remove-stripe-fw-radway-58
branch
2 times, most recently
from
December 4, 2025 09:52
1b74285 to
f12ba29
Compare
dkazanc
reviewed
Dec 11, 2025
Exceptions can be thrown, e.g. when the estimation itself fails due to running out of memory. Test is also added to covert this case.
mfep
force-pushed
the
remove-stripe-fw-radway-58
branch
from
December 16, 2025 13:34
1aabc22 to
43b46ca
Compare
dkazanc
self-requested a review
December 16, 2025 17:31
dkazanc
requested changes
Dec 16, 2025
dkazanc
left a comment
dkazanc
left a comment
Collaborator
There was a problem hiding this comment.
In HTTomo we also have another runner, a so-called sweep runner that performs a search/sweep over the set of given parameters. Because Paganin filter has a kernel of certain size we must take an area normally bigger or equal to the size of that kernel.
So in this function we try to estimate how large the vertical crop must be based on how many slices fit the GPU memory. This is still calling an older memory estimator and the associated test actually fails as well. So we need to change that bit accordingly. We just need to know that with given parameters how many vertical slices would fit, exactly what the iterative estimator can do. Can this be fixed please?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove_stripe_fwhttomo-backends#82Checklist