Repository navigation
Communicate min block len only on first block in section - #622
Merged
Merged
Conversation
Collaborator
|
Cool, I'll have a look if a test can be added to guard against a regression, I think it may not be too difficult to do. |
yousefmoazzam
force-pushed
the
min-block-len-communication
branch
2 times, most recently
from
September 2, 2025 15:01
62b468b to
097ac25
Compare
The reason that checking if the reduce method on the communicator was called is used as a proxy for checking if the minimum block length was communicated is because the former can be done with one MPI process (via mocking the size of the communicator). On the other hand, checking directly if the minimum block length was communicated or not would require running two or more processes, which is less convenient in unit tests.
yousefmoazzam
force-pushed
the
min-block-len-communication
branch
from
September 11, 2025 12:38
097ac25 to
540380f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like a PR needed for this after the confirmation on the improvement made by Radway.
Fixes #ISSUE
Checklist