Add a device setup plan to setup the pin tip detection parameters#1858
Add a device setup plan to setup the pin tip detection parameters#1858noemifrisina merged 26 commits intomainfrom
Conversation
…rameter files to where the bluesky scratch is
…for-pintip-params
noemifrisina
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1858 +/- ##
=======================================
Coverage 99.07% 99.07%
=======================================
Files 295 297 +2
Lines 11279 11298 +19
=======================================
+ Hits 11175 11194 +19
Misses 104 104 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DominicOram
left a comment
DominicOram
left a comment
There was a problem hiding this comment.
Thanks, couple of small comments, also tests would be good.
| pin_tip_detect_device: PinTipDetection, | ||
| parameters: OAVParameters, | ||
| ): | ||
| set_using_group = partial(bps.abs_set, group="pin_tip_parameters") |
There was a problem hiding this comment.
Should: Would be good if we passed this group in and so we can make the behaviour the same in the mx-bluesky case
There was a problem hiding this comment.
Could: We could also add a wait parameter to the plan that optionally waits on the group at the end
|
Also, can you make the changes for |
Yeah I thought I'd leave that for after all the i19 changes are done though |
…for-pintip-params
) * Add OAV1 and OAV2 devices to i19-1 and change the locations of the parameter files to where the bluesky scratch is * Add PinTipDetection devices to i19_1 * Make a new device where beam centre PVs are writable * And maybe save the device * Remove unneeded inherit from OAV * Move pin tip params plan in from mx-bluesky * Rename some things * Aaaand save * Add back oav for clarity * Add plan name to setup_device * Try committing and check CI * Fill in test * And maybe don't forget half the line * Change some names * A couple of docstrings * Add docstring * Make group and wait input arguments of the plan
2 participants
Move in plan to set up parameters for pin tip detection from mx-bluesky
Needed for i19-bluesky#116
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}