Skip to content

add explanatory docstrings to log.py#1854

Merged
Villtord merged 6 commits intomainfrom
logging_docs
Feb 6, 2026
Merged

add explanatory docstrings to log.py#1854
Villtord merged 6 commits intomainfrom
logging_docs

Conversation

@Villtord
Copy link
Copy Markdown
Contributor

Fixes #459

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.03%. Comparing base (5951083) to head (d50aa29).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1854   +/-   ##
=======================================
  Coverage   99.03%   99.03%           
=======================================
  Files         305      305           
  Lines       11519    11519           
=======================================
  Hits        11408    11408           
  Misses        111      111           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Villtord Villtord marked this pull request as ready for review January 23, 2026 11:22
@Villtord Villtord requested a review from a team as a code owner January 23, 2026 11:22
Copy link
Copy Markdown
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks.

@Villtord Villtord enabled auto-merge (squash) February 6, 2026 10:05
@Villtord Villtord merged commit 1d5983f into main Feb 6, 2026
7 checks passed
@Villtord Villtord deleted the logging_docs branch February 6, 2026 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs: Document how logging works in dodal

2 participants