Bug/mp deadlock#42
Open
zherbz wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stormhub works out of the box when Threads=True (ThreadPoolExecutor), but not when Threads=False (ProcessPoolExecutor), regardless of how you size your EC2,
Root cause: s3fs/fsspec (used for S3 AORC zarr access) starts a background thread running an asyncio event loop as part of its async filesystem implementation. When ProcessPoolExecutor creates workers using Linux's default fork start method, only the forking thread survives in each child process — but the asyncio background thread's internal locks are inherited in the locked state. When a worker then calls and tries to schedule async I/O, it blocks forever waiting for those locks.
The fix is to use spawn as the multiprocessing context, which creates fresh worker processes that don't inherit the parent's thread/lock state.