Skip to content

docs(dvc-com-plugin): add missing README.md to unblock crates.io publish#1213

Merged
Benoît Cortier (CBenoit) merged 1 commit intoDevolutions:masterfrom
gabrielbauman:gbauman/fix-release-plz
Apr 10, 2026
Merged

docs(dvc-com-plugin): add missing README.md to unblock crates.io publish#1213
Benoît Cortier (CBenoit) merged 1 commit intoDevolutions:masterfrom
gabrielbauman:gbauman/fix-release-plz

Conversation

@gabrielbauman
Copy link
Copy Markdown
Contributor

@gabrielbauman Gabriel Bauman (gabrielbauman) commented Apr 9, 2026

Summary

  • Adds a README.md to ironrdp-dvc-com-plugin, which declares readme = "README.md" in its Cargo.toml but was missing the file.

Problem

The Release crates workflow fails when release-plz attempts to cargo publish the ironrdp-dvc-com-plugin crate:

error: readme `README.md` does not appear to exist
  (relative to crates/ironrdp-dvc-com-plugin)

This blocks publishing of any crate that follows ironrdp-dvc-com-plugin in the dependency graph.

Fix

Added a README consistent with other crates in the workspace, describing the crate's purpose, architecture, and linking to relevant Microsoft documentation.

Note on the release-plz PR CI failure

The CI failure on PR #1212 (release-plz/2026-04-09T06-06-06Z) is a separate issue: the lock file check fails because the release-plz branch's lock files have drifted from master after subsequent commits (e.g. #1203). This will (hopefully) self-resolve when release-plz regenerates its PR on the next cycle after this fix merges.

The ironrdp-dvc-com-plugin Cargo.toml declares readme = "README.md" but
the file did not exist, causing cargo publish to fail during the
release-crates workflow.
Copilot AI review requested due to automatic review settings April 9, 2026 16:47
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the missing README.md file required by ironrdp-dvc-com-plugin’s Cargo.toml (readme = "README.md"), unblocking cargo publish in the release workflow for the workspace.

Changes:

  • Add crates/ironrdp-dvc-com-plugin/README.md describing crate purpose and architecture
  • Include references to relevant Microsoft documentation for DVC client components

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Member

@CBenoit Benoît Cortier (CBenoit) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@CBenoit Benoît Cortier (CBenoit) changed the title fix(dvc-com-plugin): add missing README.md to unblock crates.io publish docs(dvc-com-plugin): add missing README.md to unblock crates.io publish Apr 10, 2026
@CBenoit Benoît Cortier (CBenoit) merged commit 6baf726 into Devolutions:master Apr 10, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants